Move --sourcemap to scripts instead of Invoke-Build

[JustinGrote]

PR Summary

ESBuild does not currently generate sourcemaps for debugging. This enables that generation and I verified that vsce does not include the sourcemaps when packaging.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

• PR has a meaningful title
• Summarized changes
• PR has tests
• This PR is ready to merge and is not work in progress
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

[andyleejordan]

Isn't evanw/esbuild#944 an issue?

vscode-powershell/vscode-powershell.build.ps1

Lines 97 to 107 in bf54870

	# TODO: When supported we should use `esbuild` for the tests too. Although
	# we now use `esbuild` to transpile, bundle, and minify the extension, we
	# still use `tsc` to transpile everything in `src` and `test` because the VS
	# Code test runner expects individual files (and globs them at runtime).
	# Unfortunately `esbuild` doesn't support emitting 1:1 files (yet).
	# https://github.com/evanw/esbuild/issues/944
	switch ($Configuration) {
	"Debug" { Invoke-BuildExec { & npm run build -- --sourcemap } }
	"Release" { Invoke-BuildExec { & npm run build -- --minify } }
	}
	}

[andyleejordan]

The build script adds --sourcemap on debug and --minify on release.

[JustinGrote]

I'm using build watch and not the build script, that's probably why, it happens with "run extension" but not run tests because the file that it uses to run is different for both. Let me think about this tomorrow, I have an idea how to do it better.

[andyleejordan]

@JustinGrote I gotchu.

[JustinGrote]

@andyleejordan thanks! I was going to just put it in the watch npm script but as long as it doesn't hurt anything in main (it shouldn't since the tsc source maps shouldn't conflict) I'm good with it there, they take an insignificant amount of additional time to generate.