Skip to content

Add attachDotnetDebugger debug option #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 11, 2023
Merged

Add attachDotnetDebugger debug option #3903

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
15f65cf
Add attachDotnetDebugger debug option
JustinGrote Apr 1, 2022
43da008
Add explicit type to createDebugSessionFeatureStub
JustinGrote Apr 10, 2023
22d308f
Eliminate race condition from RunCode test that is making it flaky on…
JustinGrote Apr 10, 2023
7616258
Clarify how WaitEvent returns
JustinGrote Apr 10, 2023
e5f2340
Forgot to register the event prior to the debug start
JustinGrote Apr 10, 2023
1bcd565
Make StructuredClone Dependency Explicit
JustinGrote Apr 10, 2023
ce23551
Update all vscode imports in DebugSession to destructured syntax
JustinGrote Apr 10, 2023
2c6e818
Refix writeandshowerror from await to void
JustinGrote Apr 10, 2023
efc6756
Forgive resolveDebugConfiguration not having an await
JustinGrote Apr 10, 2023
aa8a1ad
Remove private config reference as it is unused and update tests
JustinGrote Apr 10, 2023
5c72a06
Bump PSStandard.Library to 5.1.1
JustinGrote Apr 10, 2023
fcaeaab
Fix typo
JustinGrote Apr 10, 2023
441db78
Remove note about C# extension because it happens later
JustinGrote Apr 11, 2023
719275b
Add back cleanup
JustinGrote Apr 11, 2023
3e0c28f
Merge branch 'main' into binaryModuleDebug
JustinGrote Apr 11, 2023
24f9b64
Move csharp extension installation outside of process
JustinGrote Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ logs/
modules
modules/
node_modules/
obj/
bin/
out/
sessions/
test/.vscode/
Expand Down
6 changes: 5 additions & 1 deletion examples/.vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,9 @@
// Use a custom PowerShell Script Analyzer settings file for this workspace.
// Relative paths for this setting are always relative to the workspace root dir.
"powershell.scriptAnalysis.settingsPath": "./PSScriptAnalyzerSettings.psd1",
"files.defaultLanguage": "powershell"
"files.defaultLanguage": "powershell",
// Suppresses some first-run messages
"git.openRepositoryInParentFolders": "never",
"csharp.suppressDotnetRestoreNotification": true,
"extensions.ignoreRecommendations": true
}
30 changes: 28 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,12 @@
"@types/rewire": "2.5.28",
"@types/semver": "7.3.13",
"@types/sinon": "10.0.13",
"@types/ungap__structured-clone": "^0.3.0",
"@types/uuid": "9.0.1",
"@types/vscode": "1.67.0",
"@typescript-eslint/eslint-plugin": "5.57.0",
"@typescript-eslint/parser": "5.57.1",
"@ungap/structured-clone": "^1.0.2",
"@vscode/test-electron": "2.3.0",
"@vscode/vsce": "2.18.0",
"esbuild": "0.17.15",
Expand Down Expand Up @@ -522,6 +524,16 @@
"type": "boolean",
"description": "Determines whether a temporary PowerShell Extension Terminal is created for each debugging session, useful for debugging PowerShell classes and binary modules. Overrides the user setting 'powershell.debugging.createTemporaryIntegratedConsole'.",
"default": false
},
"attachDotnetDebugger": {
"type": "boolean",
"description": "If specified, a C# debug session will be started and attached to the new temporary extension terminal. This does nothing unless 'powershell.debugging.createTemporaryIntegratedConsole' is also specified.",
"default": false
},
"dotnetDebuggerConfigName": {
"type": "string",
"description": "If you would like to use a custom coreclr attach debug launch configuration for the debug session, specify the name here. Otherwise a default basic config will be used. The config must be a coreclr attach config. Launch configs are not supported.",
"default": false
}
}
},
Expand Down
Loading