Add quickfix functionality #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kapilmb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
Nice! I'll hold on this for a bit because I'll need to fix up the code slightly due to some refactoring I'm finishing up now. |
|
@daviwil do you want me to rebase the changes over the refactored changes? |
EditorServices invokes PSScriptAnalyzer by passing `ScriptDefinition` paramter and not `Path` parameter. This results in null value of `ScriptPath` property of the returned diagnostic record which in turns leads to null value of `edit.file`. Therefore, we need to retrieve file path from the active editor.
kapilmb
force-pushed
the
kapilmb/code-actions
branch
from
0cc5639 to
378a4cb
Compare
|
@daviwil rebased on recent changes to master. |
|
Thanks a lot for rebasing this on the new extension design. Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.