Skip to content
This repository was archived by the owner on Jun 13, 2024. It is now read-only.

Issue 340 - Prefer Trusted Repositories #481

Closed
wants to merge 5 commits into from
Closed

Issue 340 - Prefer Trusted Repositories #481

wants to merge 5 commits into from

Conversation

awickham10
Copy link
Contributor

This addresses a portion of issue #340.

  • Get-PSRepository now returns trusted repos, then untrusted repos. They are also sorted alphabetically.
  • Install-Module now does a Find-Module based on the parameters and if there are multiple repositories found, the first result is picked and set as the Source parameter for Install-Package.

Tests were added for both changes. I'm concerned that Find-Module will have a performance impact, but I'm not sure how else to do that check unless it's done at the PackageManagement\Install-Package function instead.

@alerickson
Copy link
Member

Thanks for putting in this PR! I’ll take a look at it within the next couple days. Just wanted to give you an update

@awickham10
Copy link
Contributor Author

Thanks for putting in this PR! I’ll take a look at it within the next couple days. Just wanted to give you an update

No rush, I'm obviously still working through some kinks 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants