Refactor Nuget operations out of Publish-PSArtifactUtility function

src/PowerShellGet/private/functions/New-NugetPackage.ps1

@@ -0,0 +1,115 @@
+function New-NugetPackage {
+    [CmdletBinding()]
+    Param(
+        [Parameter(Mandatory = $true)]
+        [string]$NuspecPath,
+
+        [Parameter(Mandatory = $true)]
+        [string]$NugetPackageRoot,
+
+        [Parameter()]
+        [string]$OutputPath = $NugetPackageRoot,
+
+        [Parameter(Mandatory = $true, ParameterSetName = "UseNuget")]
+        [string]$NugetExePath,
+
+        [Parameter(ParameterSetName = "UseDotnetCli")]
+        [switch]$UseDotnetCli
+
+    )
+    Set-StrictMode -Off
+
+    if (-Not(Test-Path -Path $NuspecPath -PathType Leaf)) {
+        throw "A nuspec file does not exist at $NuspecPath, provide valid path to a .nuspec"
+    }
+
+    if (-Not(Test-Path -Path $NugetPackageRoot)) {
+        throw "NugetPackageRoot $NugetPackageRoot does not exist"
+    }
+
+
+    if ($PSCmdlet.ParameterSetName -eq "UseNuget") {
+        if (-Not(Test-Path -Path $NuGetExePath)) {
+            throw "Nuget.exe does not exist at $NugetExePath, provide a valid path to nuget.exe"
+        }
+
+        $ArgumentList = @("pack")
+        $ArgumentList += "`"$NuspecPath`""
+        $ArgumentList += "-outputdirectory `"$OutputPath`""
+
+        $processStartInfo = New-Object System.Diagnostics.ProcessStartInfo
+        $processStartInfo.FileName = $NugetExePath
+        $processStartInfo.RedirectStandardError = $true
+        $processStartInfo.RedirectStandardOutput = $true
+        $processStartInfo.UseShellExecute = $false
+        $processStartInfo.Arguments = $ArgumentList
+
+        $process = New-Object System.Diagnostics.Process
+        $process.StartInfo = $processStartInfo
+        $process.Start() | Out-Null
+        $process.WaitForExit()
+
+        if (-Not ($process.ExitCode -eq 0 )) {
+            $stdErr = $process.StandardError.ReadToEnd()
+            throw "nuget.exe failed to pack $stdErr"
+        }
+    }
+
+    if ($PSCmdlet.ParameterSetName -eq "UseDotnetCli") {
+        #perform dotnet pack using a temporary project file.
+        $dotnetCliPath = (Get-Command -Name "dotnet").Source
+        $tempPath = Join-Path -Path ([System.IO.Path]::GetTempPath()) -ChildPath ([System.Guid]::NewGuid()).Guid
+        New-Item -ItemType Directory -Path $tempPath -Force | Out-Null
+
+        $CsprojContent = @"
+            <Project Sdk="Microsoft.NET.Sdk">
+            <PropertyGroup>
+                <AssemblyName>NotUsed</AssemblyName>
+                <Description>Temp project used for creating nupkg file.</Description>
+                <TargetFramework>netcoreapp2.0</TargetFramework>
+                <IsPackable>true</IsPackable>
+            </PropertyGroup>
+            </Project>
+"@
+        $projectFile = New-Item -ItemType File -Path $tempPath -Name "Temp.csproj"
+        Set-Content -Value $CsprojContent -Path $projectFile
+
+        #execution
+
+        $ArgumentList = @("pack")
+        $ArgumentList += "`"$projectFile`""
+        $ArgumentList += "/p:NuspecFile=`"$NuspecPath`""
+        $ArgumentList += "--output `"$OutputPath`""
+
+        $processStartInfo = New-Object System.Diagnostics.ProcessStartInfo
+        $processStartInfo.FileName = $dotnetCliPath
+        $processStartInfo.RedirectStandardError = $true
+        $processStartInfo.RedirectStandardOutput = $true
+        $processStartInfo.UseShellExecute = $false
+        $processStartInfo.Arguments = $ArgumentList
+
+        $process = New-Object System.Diagnostics.Process
+        $process.StartInfo = $processStartInfo
+        $process.Start() | Out-Null
+        $process.WaitForExit()
+
+        if (Test-Path -Path $tempPath) {
+            Remove-Item -Path $tempPath -Force -Recurse
+        }
+
+        if (-Not ($process.ExitCode -eq 0 )) {
+            $stdOut = $process.StandardOutput.ReadToEnd()
+            throw "dotnet cli failed to pack $stdOut"
+        }
+
+    }
+
+    $stdOut = $process.StandardOutput.ReadToEnd()
+    $stdOut -match "Successfully created package '(.*.nupkg)'" | Out-Null
+    $nupkgFullFile = $matches[1]
+
+    $stdOut = $process.StandardOutput.ReadToEnd()
+
+    Write-Verbose -Message $stdOut
+    Write-Output $nupkgFullFile
+}

src/PowerShellGet/private/functions/New-NuspecFile.ps1

@@ -0,0 +1,129 @@
+function New-NuspecFile {
+    [CmdletBinding()]
+    Param(
+        [Parameter(Mandatory = $true)]
+        [string]$OutputPath,
+
+        [Parameter(Mandatory = $true)]
+        [string]$Id,
+
+        [Parameter(Mandatory = $true)]
+        [version]$Version,
+
+        [Parameter(Mandatory = $true)]
+        [string]$Description,
+
+        [Parameter(Mandatory = $true)]
+        [string[]]$Authors,
+
+        [Parameter()]
+        [string[]]$Owners,
+
+        [Parameter()]
+        [string]$ReleaseNotes,
+
+        [Parameter()]
+        [bool]$RequireLicenseAcceptance,
+
+        [Parameter()]
+        [string]$Copyright,
+
+        [Parameter()]
+        [string[]]$Tags,
+
+        [Parameter()]
+        [string]$LicenseUrl,
+
+        [Parameter()]
+        [string]$ProjectUrl,
+
+        [Parameter()]
+        [string]$IconUrl,
+
+        [Parameter()]
+        [PSObject[]]$Dependencies,
+
+        [Parameter()]
+        [PSObject[]]$Files
+
+    )
+    Set-StrictMode -Off
+
+    $nameSpaceUri = "http://schemas.microsoft.com/packaging/2011/08/nuspec.xsd"
+    [xml]$xml = New-Object System.Xml.XmlDocument
+
+    $xmlDeclaration = $xml.CreateXmlDeclaration("1.0", "utf-8", $null)
+    $xml.AppendChild($xmlDeclaration) | Out-Null
+
+    #create top-level elements
+    $packageElement = $xml.CreateElement("package", $nameSpaceUri)
+    $metaDataElement = $xml.CreateElement("metadata", $nameSpaceUri)
+
+    #truncate tags if they exceed nuspec specifications for size.
+    $Tags = $Tags -Join " "
+
+    if ($Tags.Length -gt 4000) {
+        Write-Warning -Message "Tag list exceeded 4000 characters and may not be accepted by some Nuget feeds."
+    }
+
+    $metaDataElementsHash = [ordered]@{
+        id                       = $Id
+        version                  = $Version
+        description              = $Description
+        authors                  = $Authors -Join ","
+        owners                   = $Owners -Join ","
+        releaseNotes             = $ReleaseNotes
+        requireLicenseAcceptance = $RequireLicenseAcceptance.ToString().ToLower()
+        copyright                = $Copyright
+        tags                     = $Tags
+    }
+
+    if ($LicenseUrl) { $metaDataElementsHash.Add("licenseUrl", $LicenseUrl) }
+    if ($ProjectUrl) { $metaDataElementsHash.Add("projectUrl", $ProjectUrl) }
+    if ($IconUrl) { $metaDataElementsHash.Add("iconUrl", $IconUrl) }
+
+    foreach ($key in $metaDataElementsHash.Keys) {
+        $element = $xml.CreateElement($key, $nameSpaceUri)
+        $elementInnerText = $metaDataElementsHash.item($key)
+        $element.InnerText = $elementInnerText
+
+        $metaDataElement.AppendChild($element) | Out-Null
+    }
+
+
+    if ($Dependencies) {
+        $dependenciesElement = $xml.CreateElement("dependencies", $nameSpaceUri)
+
+        foreach ($dependency in $Dependencies) {
+            $element = $xml.CreateElement("dependency", $nameSpaceUri)
+            $element.SetAttribute("id", $dependency.id)
+            if ($dependency.version) { $element.SetAttribute("version", $dependency.version) }
+
+            $dependenciesElement.AppendChild($element) | Out-Null
+        }
+        $metaDataElement.AppendChild($dependenciesElement) | Out-Null
+    }
+
+    if ($Files) {
+        $filesElement = $xml.CreateElement("files", $nameSpaceUri)
+
+        foreach ($file in $Files) {
+            $element = $xml.CreateElement("file", $nameSpaceUri)
+            $element.SetAttribute("src", $file.src)
+            if ($file.target) { $element.SetAttribute("target", $file.target) }
+            if ($file.exclude) { $element.SetAttribute("exclude", $file.exclude) }
+
+            $filesElement.AppendChild($element) | Out-Null
+        }
+    }
+
+    $packageElement.AppendChild($metaDataElement) | Out-Null
+    if ($filesElement) { $packageElement.AppendChild($filesElement) | Out-Null }
+
+    $xml.AppendChild($packageElement) | Out-Null
+
+    $nuspecFullName = Join-Path -Path $OutputPath -ChildPath "$Id.nuspec"
+    $xml.save($nuspecFullName)
+
+    Write-Output $nuspecFullName
+}

src/PowerShellGet/private/functions/Publish-NugetPackage.ps1

@@ -0,0 +1,80 @@
+function Publish-NugetPackage {
+    [CmdletBinding()]
+    Param(
+        [Parameter(Mandatory = $true)]
+        [string]$NupkgPath,
+
+        [Parameter(Mandatory = $true)]
+        [string]$Destination,
+
+        [Parameter(Mandatory = $true)]
+        [string]$NugetApiKey,
+
+        [Parameter(ParameterSetName = "UseNuget")]
+        [string]$NugetExePath,
+
+        [Parameter(ParameterSetName = "UseDotnetCli")]
+        [switch]$UseDotnetCli
+    )
+    Set-StrictMode -Off
+
+    $Destination = $Destination.TrimEnd("\")
+
+    if ($PSCmdlet.ParameterSetName -eq "UseNuget") {
+        $ArgumentList = @('push')
+        $ArgumentList += "`"$NupkgPath`""
+        $ArgumentList += @('-source', "`"$Destination`"")
+        $ArgumentList += @('-apikey', "`"$NugetApiKey`"")
+        $ArgumentList += '-NonInteractive'
+
+        #use processstartinfo and process objects here as it allows stderr redirection in memory rather than file.
+        $processStartInfo = New-Object System.Diagnostics.ProcessStartInfo
+        $processStartInfo.FileName = $NugetExePath
+        $processStartInfo.RedirectStandardError = $true
+        $processStartInfo.RedirectStandardOutput = $true
+        $processStartInfo.UseShellExecute = $false
+        $processStartInfo.Arguments = $ArgumentList
+
+        $process = New-Object System.Diagnostics.Process
+        $process.StartInfo = $processStartInfo
+        $process.Start() | Out-Null
+        $process.WaitForExit()
+
+        if (-Not ($process.ExitCode -eq 0 )) {
+            $stdErr = $process.StandardError.ReadToEnd()
+            throw "nuget.exe failed to push $stdErr"
+        }
+    }
+
+    if ($PSCmdlet.ParameterSetName -eq "UseDotnetCli") {
+        #perform dotnet pack using a temporary project file.
+        $dotnetCliPath = (Get-Command -Name "dotnet").Source
+
+        $ArgumentList = @('nuget')
+        $ArgumentList += 'push'
+        $ArgumentList += "`"$NupkgPath`""
+        $ArgumentList += @('--source', "`"$Destination`"")
+        $ArgumentList += @('--api-key', "`"$NugetApiKey`"")
+
+        #use processstartinfo and process objects here as it allows stdout redirection in memory rather than file.
+        $processStartInfo = New-Object System.Diagnostics.ProcessStartInfo
+        $processStartInfo.FileName = $dotnetCliPath
+        $processStartInfo.RedirectStandardError = $true
+        $processStartInfo.RedirectStandardOutput = $true
+        $processStartInfo.UseShellExecute = $false
+        $processStartInfo.Arguments = $ArgumentList
+
+        $process = New-Object System.Diagnostics.Process
+        $process.StartInfo = $processStartInfo
+        $process.Start() | Out-Null
+        $process.WaitForExit()
+
+        if (-Not ($process.ExitCode -eq 0)) {
+            $stdOut = $process.StandardOutput.ReadToEnd()
+            throw "dotnet cli failed to nuget push $stdOut"
+        }
+    }
+
+    $stdOut = $process.StandardOutput.ReadToEnd()
+    Write-Verbose -Message $stdOut
+}