This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Add Support for SourceLocation and ScriptSourceLocation Using Same URI #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
force-pushed
the
development
branch
from
c3601a2 to
1c677b8
Compare
|
@tnieto88 thanks for the PR! Could you add a test for both of those fixes? Though I'm more concerned with testing for #384. |
|
@alerickson I'll get some tests added. |
…into sourcefix
|
@alerickson Tests have been added. |
|
Thank you @tnieto88! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #384 and #76.