This repository was archived by the owner on Jun 13, 2024. It is now read-only.
WIP: Fix Catalog tests when running with code in the cloned tree #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmanikm
reviewed
Oct 8, 2018
bmanikm
reviewed
Oct 8, 2018
|
Why are the files being moved into a new src directory? Can't $env:psmodulepath include clonepath\PowerShellGet? |
alerickson
approved these changes
Oct 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to ensure that it works to run the tests against the code that is in the main tree (rather than only after publishing), because it makes for a quicker compile/test cycle.
At present, when you set $env:psmodulepath to include clonepath, as suggested in the README.md, some of the catalog tests fail. This is because clonepath\tests\testmodules is now under $env:psmodulepath, and Install-Module ContosoServer fails because ContosoServer is already 'installed' (it isn't really, but Get-Module -ListAvailable picks it up).
Tried a couple of ways to fix this, but best so far is to move all the module code under src. Then $env:psmodulepath can include clonepath\src without picking up the test modules. Hence large number of files 'changed' but they have just moved directory.
Also some utility funcs which are not used yet but will hopefully be useful in future.
Thoughts?