Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PowerShellStandard.Library, PowerShell.SDK, NET.Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on any branch #859

Merged
merged 5 commits into from
Jan 30, 2019
Merged

Upgrade PowerShellStandard.Library, PowerShell.SDK, NET.Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on any branch #859

merged 5 commits into from
Jan 30, 2019

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Jan 22, 2019 •
edited
Loading

This time I did not upgrade the XUnit packages as per the last PR feedback

bergmeister
bergmeister commented Jan 22, 2019
View reviewed changes
test/PowerShellEditorServices.Test.Host/PowerShellEditorServices.Test.Host.csproj Outdated
@@ -22,13 +22,13 @@
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.1' ">
<PackageReference Include="Microsoft.PowerShell.SDK" Version="6.1.0-rc.1" />
<PackageReference Include="Microsoft.PowerShell.SDK" Version="6.1.0" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjmholt Could we even go for 6.1.2 for the SDK or is that breaking if someone uses e.g. 6.1.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would be perfect. This is just for testing (not distributed to users), and there should be no breaking changes between 6.1.1 and 6.1.2 anyway.

rjmholt
rjmholt approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bergmeister!

appveyor.yml
@@ -3,11 +3,6 @@ image: Visual Studio 2017
clone_depth: 10
skip_tags: true

branches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TylerLeonhardt do you think master and legacy/1.x is what we might want here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to no have anything in there because otherwise i cannot run the tests in my fork branches

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we were misusing this now that I'm reading up on it. Looks like it should be fine to take out

test/PowerShellEditorServices.Test.Host/PowerShellEditorServices.Test.Host.csproj Outdated
@@ -22,13 +22,13 @@
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.1' ">
<PackageReference Include="Microsoft.PowerShell.SDK" Version="6.1.0-rc.1" />
<PackageReference Include="Microsoft.PowerShell.SDK" Version="6.1.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that would be perfect. This is just for testing (not distributed to users), and there should be no breaking changes between 6.1.1 and 6.1.2 anyway.

TylerLeonhardt
TylerLeonhardt approved these changes Jan 23, 2019
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to update the version of the PowerShell SDK used :)

@bergmeister
Copy link
Contributor Author

@TylerLeonhardt Ok, I bumped the ps sdk to the latest version. I think we can merge now.

@bergmeister bergmeister changed the title Upgrade various NuGet packages and enable AppVeyor build on branches to run tests in forks before PR time Upgrade PowerShellStandard.Library, PowerShell.SDK, Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on branches to run tests in forks before PR time Jan 24, 2019
@bergmeister bergmeister changed the title Upgrade PowerShellStandard.Library, PowerShell.SDK, Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on branches to run tests in forks before PR time Upgrade PowerShellStandard.Library, PowerShell.SDK, NET.Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on branches to run tests in forks before PR time Jan 24, 2019
@bergmeister bergmeister changed the title Upgrade PowerShellStandard.Library, PowerShell.SDK, NET.Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on branches to run tests in forks before PR time Upgrade PowerShellStandard.Library, PowerShell.SDK, NET.Test.SDK and Serilog NuGet packages to latest released version and enable AppVeyor build on any branch Jan 24, 2019
@rjmholt rjmholt merged commit 2c5f8cf into PowerShell:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@rkeithhill rkeithhill Awaiting requested review from rkeithhill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergmeister @TylerLeonhardt @rjmholt