Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VSTS signing step #722

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Add VSTS signing step #722

merged 2 commits into from
Aug 14, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Aug 14, 2018

Adds a VSTS variable replacement step for signing using PowerShell's signing update script

@rjmholt rjmholt requested a review from TylerLeonhardt August 14, 2018 22:17
TylerLeonhardt
TylerLeonhardt approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM signing is fun 👍

@TylerLeonhardt
Copy link
Member

might be worth also adding this to vscode-powershell if it's easy to do so those use the same vsts.ps1 script

@rjmholt rjmholt merged commit ee66654 into PowerShell:master Aug 14, 2018
@rjmholt rjmholt deleted the signing-script-update branch December 12, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmholt @TylerLeonhardt