Skip to content

workaround to support inmemory:// #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2018
Merged

workaround to support inmemory:// #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909e7f7
workaround 711
TylerLeonhardt Jul 26, 2018
0dce01e
add test
TylerLeonhardt Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/PowerShellEditorServices.Host/CodeLens/ReferencesCodeLensProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ private static string GetFileUri(string filePath)
{
// If the file isn't untitled, return a URI-style path
return
!filePath.StartsWith("untitled")
!filePath.StartsWith("untitled") && !filePath.StartsWith("inmemory")
? new Uri("file://" + filePath).AbsoluteUri
: filePath;
}
}
}
}
2 changes: 1 addition & 1 deletion src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,7 @@ public static string GetFileUri(string filePath)
{
// If the file isn't untitled, return a URI-style path
return
!filePath.StartsWith("untitled")
!filePath.StartsWith("untitled") && !filePath.StartsWith("inmemory")
? new Uri("file://" + filePath).AbsoluteUri
: filePath;
}
Expand Down
1 change: 1 addition & 0 deletions test/PowerShellEditorServices.Test/Session/WorkspaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public void CanDetermineIsPathInMemory()
// Test short non-file paths
new { IsInMemory = true, Path = "untitled:untitled-1" },
new { IsInMemory = true, Path = shortUriForm },
new { IsInMemory = true, Path = "inmemory://foo.ps1" },

// Test long non-file path - known to have crashed PSES
new { IsInMemory = true, Path = longUriForm },
Expand Down