Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Diagnostic logging from logging to stdio when stdio is present #709

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Stop Diagnostic logging from logging to stdio when stdio is present #709

merged 1 commit into from
Jul 25, 2018

Conversation

TylerLeonhardt
Copy link
Member

when Start-EditorServices logs to stdio when PSES is using stdio to communicate, the logs are treated as messages and PSES fails to work.

This allows you to set it to Diagnostic and also use stdio.

rkeithhill
rkeithhill approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt TylerLeonhardt merged commit d0899f7 into PowerShell:master Jul 25, 2018
@TylerLeonhardt TylerLeonhardt deleted the fix-logging-with-stdio branch July 25, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill rkeithhill approved these changes

@rjmholt rjmholt Awaiting requested review from rjmholt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerLeonhardt @rkeithhill