Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbols to modules built in Debug configuration #675

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Jun 4, 2018

This copies over the .pdb files into the module so that it can be debugged alongside the/a client. Only copies the files in the Debug configuration.

@rjmholt
Copy link
Contributor Author

rjmholt commented Jun 4, 2018

BTW, at some point I'd love to clean all this copy logic up into a big list of key/value pairs and just run a for loop over it.

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) I need this right now so I'm going to merge it.

@TylerLeonhardt TylerLeonhardt merged commit 5cc95e0 into PowerShell:master Jun 5, 2018
@rjmholt rjmholt deleted the build-symbols-in-module branch December 12, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants