Decouple ProtocolEndpoint from client and server implementations #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change decouples the ProtocolEndpoint class from the existing client and server implementations for the language and debug services. The goal here is to eventually decentralize all editor feature implementations into individual classes, so separating out the ProtocolEndpoint is the first step in achieving this. This class will now be exposed in the framework as the IMessageSender interface. This change also simplifies the LanguageServer/DebugAdapter client and server implementations, removing some unnecessary abstraction and base classes.
TylerLeonhardt
pushed a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Feb 26, 2019
…ter-whitespace Enable code formatter to enforce consistent whitespace style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change decouples the ProtocolEndpoint class from the existing
client and server implementations for the language and debug services.
The goal here is to eventually decentralize all editor feature
implementations into individual classes, so separating out the
ProtocolEndpoint is the first step in achieving this. This class will
now be exposed in the framework as the IMessageSender interface.
This change also simplifies the LanguageServer/DebugAdapter client and
server implementations, removing some unnecessary abstraction and base
classes.