Add sane defaults to Start-EditorServices
#2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andyleejordan/simple-cli
branch
5 times, most recently
from
75d37a6 to
fe22485
Compare
andyleejordan
commented
Jan 12, 2024
src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs
Outdated
Show resolved
Hide resolved
src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs
Outdated
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andyleejordan/simple-cli
branch
from
fe22485 to
1b824f1
Compare
andyleejordan
force-pushed
the
andyleejordan/simple-cli
branch
from
83192b5 to
a4bade2
Compare
6 tasks
andyleejordan
force-pushed
the
andyleejordan/simple-cli
branch
2 times, most recently
from
e5ca1d0 to
fe7fe5a
Compare
We do not need to require so many CLI flags. This continues to run the existing Emacs and Vim tests utilizing those flags as a regression scenario, and adds an additional pair of tests that launch PSES with a minimal set of flags. This also fixes the log file path to be unique per process, and to use `LogPath` as a directory instead of a file.
andyleejordan
force-pushed
the
andyleejordan/simple-cli
branch
from
fe7fe5a to
45db851
Compare
andyleejordan
added
Issue-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to require so many CLI flags.
This continues to run the existing Emacs and Vim tests utilizing those flags as a regression scenario, and adds an additional pair of tests that launch PSES with a minimal set of flags.
Resolves #1855.
Slight breaking change for CLI users of the
-LogPathparameter. It now takes a directory name instead of a log name, which makes a lot more sense because multiple log files get written to that location.