Set session failure with reason when applicable #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not updating our requirement, that apparently already changed to 4.8 as determined by testing.
Which is currently unused. It must have been in use previously because the client is expecting specific reasons. Since we need to redo this, let's remove the excess.
andyleejordan
force-pushed
the
andschwa/write-session-failure
branch
from
c7058d6 to
609a874
Compare
andyleejordan
force-pushed
the
andschwa/write-session-failure
branch
from
609a874 to
9c0bea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our session failure logic (we were no longer ever sending a "failed" status back, hence the awful experience in the client). If PowerShell does start, but detects that it's not going to work due to unsupported PowerShell or .NET Framework versions (applicable only to Windows PowerShell), we set the session status to failed and actually report the PowerShell version for use by the client's error reporting.
Note that as far as we know, our minimum .NET Framework support for Windows PowerShell is now 4.8, per PowerShell/vscode-powershell#4483.
Resolves PowerShell/vscode-powershell#4509.