Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BundledModulePath and PSReadLine loading (redux) #1638

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix BundledModulePath and PSReadLine loading (redux) #1638

merged 1 commit into from
Nov 30, 2021

Conversation

andyleejordan
Copy link
Member

This redoes prior work that was lost during the rewrite. Specifically
this actually respects the user configuration of BundledModulePath
(also used by unit tests to provide compatibililty with xUnit), and
forces the use of only our bundled PSReadLine dependency.

Essentially this redoes #1514 and #1522.

@andyleejordan
Fix BundledModulePath and PSReadLine loading (redux)
61477ab 
This redoes prior work that was lost during the rewrite. Specifically
this actually respects the user configuration of `BundledModulePath`
(also used by unit tests to provide compatibililty with xUnit), and
forces the use of only our bundled PSReadLine dependency.

Essentially this redoes #1514 and #1522.
@andyleejordan
Copy link
Member Author

andyleejordan commented Nov 30, 2021 •
edited
Loading

@SeeminglyScience, @JustinGrote, and @dkattan I discovered this while working on #1605. Specifically when debugging the first test I noticed that $Error had a real error in it, and that it was a failure to load the base commands module. Upon inspection, all this hard work had been dropped during the rewrite.

@andyleejordan andyleejordan enabled auto-merge (squash) November 30, 2021 00:35
daxian-dbw
daxian-dbw approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyleejordan andyleejordan merged commit 96a8207 into master Nov 30, 2021
@andyleejordan andyleejordan deleted the andschwa/module-path branch November 30, 2021 21:32
@andyleejordan
Copy link
Member Author

Part of #1677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

Assignees
No one assigned
Labels
Area-Startup Issue-Bug A bug to squash.
Projects
No open projects
Sea Biscuit
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @daxian-dbw