Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS 1.2 Support When Installing PackageManagement Module #1315

Merged
merged 7 commits into from
Jun 19, 2020
Merged

TLS 1.2 Support When Installing PackageManagement Module #1315

merged 7 commits into from
Jun 19, 2020

Conversation

serkanz
Copy link
Contributor

@serkanz serkanz commented Jun 17, 2020 •
edited by SydneyhSmith
Loading

To download the PackageManagement module requires TLS 1.2. Many users will get an error.

fixes #1314

fixes PowerShell/vscode-powershell#2763

@serkanz serkanz requested a review from rjmholt as a code owner June 17, 2020 10:52
@TylerLeonhardt
Copy link
Member

On line 143 there's a string that says:

PackageManagement update failed. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`

Can you change that to say:

PackageManagement update failed. This might be due to PowerShell Gallery using TLS 1.2. More info can be found at https://aka.ms/psgallerytls

TylerLeonhardt
TylerLeonhardt reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Couple small things to add

src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs Outdated Show resolved Hide resolved
@serkanz
Copy link
Contributor Author

serkanz commented Jun 18, 2020

Ok, updated the message string

On line 143 there's a string that says:

PackageManagement update failed. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`

Can you change that to say:

PackageManagement update failed. This might be due to PowerShell Gallery using TLS 1.2. More info can be found at https://aka.ms/psgallerytls

Added -Repository argument

Thanks! Couple small things to add

@serkanz
Copy link
Contributor Author

serkanz commented Jun 18, 2020

PowerShell/vscode-powershell#2763

@SydneyhSmith
Copy link
Collaborator

fixes PowerShell/vscode-powershell#2763

TylerLeonhardt
TylerLeonhardt approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for doing this!

@TylerLeonhardt TylerLeonhardt merged commit 0c2d369 into PowerShell:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install-Module -Name PackageManagement requires TLS 1.2 PackageManagement Module Update Problem
4 participants
@serkanz @TylerLeonhardt @SydneyhSmith @rjmholt