Skip to content

Make Start-Job throw terminating exception when -RunAs32 is specified in 64-bit pwsh #9143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Mar 15, 2019

PR Summary

Make Start-Job throw terminating exception when -RunAs32 is specified in 64-bit pwsh.
To start a 32-bit pwsh, you need to have the 32-bit pwsh installed.

PR Context

PR Checklist

@daxian-dbw daxian-dbw requested review from SteveL-MSFT and adityapatwardhan and removed request for BrucePay and mirichmo March 15, 2019 06:52
@daxian-dbw daxian-dbw added Area-Maintainers-Documentation specific to documentation in this repo Documentation Needed in this repo Documentation is needed in this repo CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Area-Maintainers-Documentation specific to documentation in this repo labels Mar 15, 2019
@adityapatwardhan
Copy link
Member

@daxian-dbw Can you file the bug for documentation?
Did you test the code change on a 32 bit build? We do not run 32 bit in CI.

@daxian-dbw
Copy link
Member Author

daxian-dbw commented Mar 15, 2019

Did you test the code change on a 32 bit build? We do not run 32 bit in CI.

Yes, I tested manually on a 32 bit build.

Can you file the bug for documentation?

Yes, done: MicrosoftDocs/PowerShell-Docs#4003

@adityapatwardhan
Copy link
Member

Updated the PR template with the link to the doc issue.

@adityapatwardhan
Copy link
Member

@PoshChan remind me in 65 hours

@PoshChan
Copy link
Collaborator

@adityapatwardhan, I do not understand: remind me in 65 hours

@adityapatwardhan
Copy link
Member

@PoshChan Please remind me in 65 hours

@PoshChan
Copy link
Collaborator

@adityapatwardhan, will remind you in 65 hours

@vexx32
Copy link
Collaborator

vexx32 commented Mar 16, 2019

Oh my gosh @SteveL-MSFT you made it to expect to be asked nicely?

That's fantastic! 😂

@SteveL-MSFT
Copy link
Member

@vexx32 Of course!

@PoshChan
Copy link
Collaborator

@adityapatwardhan, this is the reminder you requested 65 hours ago

@adityapatwardhan adityapatwardhan merged commit 24d3152 into PowerShell:master Mar 18, 2019
@daxian-dbw daxian-dbw deleted the runas32 branch March 18, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Documentation Needed in this repo Documentation is needed in this repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants