Skip to content

Add support empty NoteProperty in Group-Object #9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Mar 11, 2019

PR Summary

Fix #3300

PR Context

GetHashCode evaluates a hash for base object of PSObject that can be sometimes null.

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 11, 2019
@iSazonov iSazonov self-assigned this Mar 11, 2019
@iSazonov iSazonov requested a review from SteveL-MSFT March 11, 2019 08:01
Copy link
Collaborator

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice and clean. 😄

@iSazonov
Copy link
Collaborator Author

iSazonov commented Mar 11, 2019

CI-windows fail on new StopAsync test
https://powershell.visualstudio.com/PowerShell/_build/results?buildId=16358
Restarted CI-windows

@iSazonov iSazonov merged commit e75bd14 into PowerShell:master Mar 13, 2019
@iSazonov iSazonov deleted the group-object branch March 13, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group-Object fails with a NullReferenceException on empty noteproperty
3 participants