Skip to content

Add WDAC events and system lockdown notification #18893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 773 commits into from
Jan 9, 2023
Merged

Add WDAC events and system lockdown notification #18893

merged 773 commits into from
Jan 9, 2023

Conversation

PaulHigin
Copy link
Contributor

PR Summary

This PR adds new ETW events for WDAC calls, and also a start-up notification when the system is in lock down and PowerShell console runs in Constrained Language mode.

#18628

PR Context

WDAC (Windows Defender Application Control) is a Windows OS application control policy, and PowerShell complies with the system policy through added restrictions and language modes. This PR adds ETW event logging for calls PowerShell makes to WDAC in order to determine if the system is in lock down mode, and if a script file is allowed by the WDAC policy. It also adds to the PowerShell start-up banner a notification if the console is starting in Constrained Language mode due to WDAC policy.

PR Checklist

dependabot bot and others added 30 commits December 14, 2022 09:13
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot bot and others added 9 commits December 14, 2022 09:14
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps PSReadLine from 2.1.0 to 2.2.2.

---
updated-dependencies:
- dependency-name: PSReadLine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@pull-request-quantifier-deprecated

This PR has 83 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +70 -13
Percentile : 33.2%

Total files changed: 9

Change summary by file extension:
.cs : +61 -13
.resx : +9 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@PaulHigin PaulHigin added the Backport-5.1-Consider Consider to backport to Windows PowerShell 5.1 due to impact label Jan 5, 2023
@PaulHigin PaulHigin merged commit 80b5df4 into PowerShell:master Jan 9, 2023
@PaulHigin PaulHigin deleted the wdac-events branch January 9, 2023 18:40
@adityapatwardhan adityapatwardhan added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Mar 14, 2023
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-5.1-Consider Consider to backport to Windows PowerShell 5.1 due to impact CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants