Skip to content

Adding PSCore group policy definitions #10468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 12, 2019
Merged

Conversation

anmenaga
Copy link

PR Summary

Group Policy tools (e.g. gpedit.msc) use administrative template files (.admx, .adml) to populate policy settings in their user interface. This allows administrators to manage registry-based policy settings for PowerShell Core.
This PR:

  1. Adds GroupPolicy definitions (.admx, .adml) for PowerShell Core.
  2. Adds an installation script that admins can use to install PowerShell Core GroupPolicy definitions.
  3. Adds Policy settings Fall-Back functionality described in PowerShell Core Policy RFC.
  4. Adds tests for:
    *) registry-based PS Core policy settings;
    *) Fall-Back to Windows PS policy settings functionality.

PR Context

PowerShell Core Policy RFC was recently accepted, so UX related to PowerShell Core GroupPolicy settings has to me adjusted accordingly.

PR Checklist

@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 30, 2019
@anmenaga anmenaga requested a review from TravisEz13 August 30, 2019 22:53
@TravisEz13
Copy link
Member

@anmenaga I made changes. Be sure to pull changes from the branch if you need to make any more changes.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 11, 2019
@TravisEz13
Copy link
Member

@iSazonov thanks for reviewing.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 11, 2019
@joeyaiello
Copy link
Contributor

Added just a couple of comments/suggestions to the strings here, sorry for not doing it as a review (I was afraid of getting distracted 😄 )

Andrew and others added 7 commits September 12, 2019 11:32
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
@anmenaga
Copy link
Author

@joeyaiello thank you; I've updated per your suggestions.

@TravisEz13 TravisEz13 merged commit ed29ad1 into PowerShell:master Sep 12, 2019
@iSazonov iSazonov added this to the 7.0.0-preview.4 milestone Sep 13, 2019
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Sep 14, 2019
@ghost
Copy link

ghost commented Sep 19, 2019

🎉v7.0.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants