Cleanup: use the built-in type alias (#10882)

Author: iSazonov

src/Microsoft.Management.Infrastructure.CimCmdlets/CimSessionOperations.cs

@@ -448,12 +448,12 @@ internal string GetRemoveSessionObjectTarget(PSObject psObject)
                     instanceId = (Guid)psObject.Properties[instanceidPropName].Value;
                 }
 
-                if (psObject.Properties[namePropName].Value is String)
+                if (psObject.Properties[namePropName].Value is string)
                 {
                     name = (string)psObject.Properties[namePropName].Value;
                 }
 
-                if (psObject.Properties[computernamePropName].Value is String)
+                if (psObject.Properties[computernamePropName].Value is string)
                 {
                     computerName = (string)psObject.Properties[computernamePropName].Value;
                 }
@@ -637,7 +637,7 @@ internal IEnumerable<PSObject> QuerySession(IEnumerable<string> nameArray,
             {
                 bool foundSession = false;
                 WildcardPattern pattern = new WildcardPattern(name, WildcardOptions.IgnoreCase);
-                foreach (KeyValuePair<String, HashSet<CimSessionWrapper>> kvp in this.curCimSessionsByName)
+                foreach (KeyValuePair<string, HashSet<CimSessionWrapper>> kvp in this.curCimSessionsByName)
                 {
                     if (pattern.IsMatch(kvp.Key))
                     {

src/Microsoft.PowerShell.Commands.Diagnostics/GetEventCommand.cs

@@ -1142,7 +1142,7 @@ private string BuildStructuredQueryFromHashTable(EventLogSession eventLogSession
                     List<string> logPatterns = new List<string>();
                     if (hash[hashkey_logname_lc] is Array)
                     {
-                        foreach (Object elt in (Array)hash[hashkey_logname_lc])
+                        foreach (object elt in (Array)hash[hashkey_logname_lc])
                         {
                             logPatterns.Add(elt.ToString());
                         }
@@ -1167,7 +1167,7 @@ private string BuildStructuredQueryFromHashTable(EventLogSession eventLogSession
                 {
                     if (hash[hashkey_path_lc] is Array)
                     {
-                        foreach (Object elt in (Array)hash[hashkey_path_lc])
+                        foreach (object elt in (Array)hash[hashkey_path_lc])
                         {
                             StringCollection resolvedPaths = ValidateAndResolveFilePath(elt.ToString());
                             foreach (string resolvedPath in resolvedPaths)
@@ -1197,7 +1197,7 @@ private string BuildStructuredQueryFromHashTable(EventLogSession eventLogSession
                     List<string> provPatterns = new List<string>();
                     if (hash[hashkey_providername_lc] is Array)
                     {
-                        foreach (Object elt in (Array)hash[hashkey_providername_lc])
+                        foreach (object elt in (Array)hash[hashkey_providername_lc])
                         {
                             provPatterns.Add(elt.ToString());
                         }
@@ -1347,7 +1347,7 @@ private string BuildStructuredQueryFromHashTable(EventLogSession eventLogSession
         // HandleEventIdHashValue helper for hashtable structured query builder.
         // Constructs and returns EventId XPath portion as a string.
         //
-        private string HandleEventIdHashValue(Object value)
+        private string HandleEventIdHashValue(object value)
         {
             StringBuilder ret = new StringBuilder();
             Array idsArray = value as Array;
@@ -1377,7 +1377,7 @@ private string HandleEventIdHashValue(Object value)
         // HandleLevelHashValue helper for hashtable structured query builder.
         // Constructs and returns Level XPath portion as a string.
         //
-        private string HandleLevelHashValue(Object value)
+        private string HandleLevelHashValue(object value)
         {
             StringBuilder ret = new StringBuilder();
             Array levelsArray = value as Array;
@@ -1407,15 +1407,15 @@ private string HandleLevelHashValue(Object value)
         // HandleKeywordHashValue helper for hashtable structured query builder.
         // Constructs and returns Keyword XPath portion as a string.
         //
-        private string HandleKeywordHashValue(Object value)
+        private string HandleKeywordHashValue(object value)
         {
             Int64 keywordsMask = 0;
             Int64 keywordLong = 0;
 
             Array keywordArray = value as Array;
             if (keywordArray != null)
             {
-                foreach (Object keyword in keywordArray)
+                foreach (object keyword in keywordArray)
                 {
                     if (KeywordStringToInt64(keyword.ToString(), ref keywordLong))
                     {
@@ -1442,7 +1442,7 @@ private string HandleKeywordHashValue(Object value)
         // Handles both SIDs and domain account names.
         // Writes an error and returns an empty string if the SID or account names are not valid.
         //
-        private string HandleContextHashValue(Object value)
+        private string HandleContextHashValue(object value)
         {
             SecurityIdentifier sidCandidate = null;
             try
@@ -1478,7 +1478,7 @@ private string HandleContextHashValue(Object value)
         // Constructs and returns TimeCreated XPath portion as a string.
         // NOTE that it also handles the hashtable "endtime" value (if supplied).
         //
-        private string HandleStartTimeHashValue(Object value, Hashtable hash)
+        private string HandleStartTimeHashValue(object value, Hashtable hash)
         {
             StringBuilder ret = new StringBuilder();
             DateTime startTime = new DateTime();
@@ -1521,7 +1521,7 @@ private string HandleStartTimeHashValue(Object value, Hashtable hash)
         // Constructs and returns TimeCreated XPath portion as a string.
         // NOTE that it also handles the hashtable "starttime" value (if supplied).
         //
-        private string HandleEndTimeHashValue(Object value, Hashtable hash)
+        private string HandleEndTimeHashValue(object value, Hashtable hash)
         {
             StringBuilder ret = new StringBuilder();
             DateTime endTime = new DateTime();
@@ -1565,7 +1565,7 @@ private string HandleEndTimeHashValue(Object value, Hashtable hash)
         // HandleDataHashValue helper for hashtable structured query builder.
         // Constructs and returns EventData/Data XPath portion as a string.
         //
-        private string HandleDataHashValue(Object value)
+        private string HandleDataHashValue(object value)
         {
             StringBuilder ret = new StringBuilder();
             Array dataArray = value as Array;
@@ -1596,7 +1596,7 @@ private string HandleDataHashValue(Object value)
         // Constructs and returns named event data field XPath portion as a string.
         // Fix Issue #2327
         //
-        private string HandleNamedDataHashValue(String key, object value)
+        private string HandleNamedDataHashValue(string key, object value)
         {
             StringBuilder ret = new StringBuilder();
             Array dataArray = value as Array;
@@ -1850,7 +1850,7 @@ private void CheckHashTablesForNullValues()
                         Array eltArray = value as Array;
                         if (eltArray != null)
                         {
-                            foreach (Object elt in eltArray)
+                            foreach (object elt in eltArray)
                             {
                                 if (elt == null)
                                 {

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs

@@ -2597,7 +2597,7 @@ internal bool AssignProcessToJobObject(Process process)
         /// Checks to see if the JobObject is empty (has no assigned processes).
         /// If job is empty the auto reset event supplied as input would be set.
         /// </summary>
-        internal void CheckJobStatus(Object stateInfo)
+        internal void CheckJobStatus(object stateInfo)
         {
             ManualResetEvent emptyJobAutoEvent = (ManualResetEvent)stateInfo;
             int dwSize = 0;

src/Microsoft.PowerShell.Commands.Utility/commands/utility/FormatAndOutput/OutGridView/OutGridViewCommand.cs

@@ -380,7 +380,7 @@ internal NonscalarTypeHeader(OutGridViewCommand parentCmd, PSObject input) : bas
                     int index = 0;
                     foreach (string typeName in input.TypeNames)
                     {
-                        if (index > 0 && (typeName.Equals(typeof(Object).FullName, StringComparison.OrdinalIgnoreCase) ||
+                        if (index > 0 && (typeName.Equals(typeof(object).FullName, StringComparison.OrdinalIgnoreCase) ||
                             typeName.Equals(typeof(MarshalByRefObject).FullName, StringComparison.OrdinalIgnoreCase)))
                         {
                             break;

src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetHash.cs

@@ -244,7 +244,7 @@ internal static class HashAlgorithmNames
         /// <summary>
         /// Init a hash algorithm.
         /// </summary>
-        protected void InitHasher(String Algorithm)
+        protected void InitHasher(string Algorithm)
         {
             try
             {

src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetRandomCommand.cs

@@ -21,7 +21,7 @@ namespace Microsoft.PowerShell.Commands
     /// <!-- author: LukaszA -->
     [Cmdlet(VerbsCommon.Get, "Random", DefaultParameterSetName = GetRandomCommand.RandomNumberParameterSet,
         HelpUri = "https://go.microsoft.com/fwlink/?LinkID=113446", RemotingCapability = RemotingCapability.None)]
-    [OutputType(typeof(Int32), typeof(Int64), typeof(Double))]
+    [OutputType(typeof(Int32), typeof(Int64), typeof(double))]
     public class GetRandomCommand : PSCmdlet
     {
         #region Parameter set handling

src/Microsoft.PowerShell.Commands.Utility/commands/utility/New-Object.cs

@@ -404,7 +404,7 @@ private class ComCreateInfo
 
         private ComCreateInfo createInfo;
 
-        private void STAComCreateThreadProc(Object createstruct)
+        private void STAComCreateThreadProc(object createstruct)
         {
             ComCreateInfo info = (ComCreateInfo)createstruct;
             try

src/Microsoft.PowerShell.Commands.Utility/commands/utility/ObjectCommandComparer.cs

@@ -75,7 +75,7 @@ internal CultureInfo Culture
         /// </summary>
         /// <param name="inputObject">Input Object.</param>
         /// <returns>True if both the objects are same or else returns false.</returns>
-        public override bool Equals(Object inputObject)
+        public override bool Equals(object inputObject)
         {
             ObjectCommandPropertyValue objectCommandPropertyValueObject = inputObject as ObjectCommandPropertyValue;
             if (objectCommandPropertyValueObject == null)

src/Microsoft.PowerShell.Commands.Utility/commands/utility/ShowCommand/ShowCommandProxy.cs

@@ -75,9 +75,9 @@ internal string GetShowAllModulesCommand()
             return (string)_graphicalHostReflectionWrapper.CallStaticMethod("GetShowAllModulesCommand", false, true);
         }
 
-        internal Dictionary<String, ShowCommandModuleInfo> GetImportedModulesDictionary(object[] moduleObjects)
+        internal Dictionary<string, ShowCommandModuleInfo> GetImportedModulesDictionary(object[] moduleObjects)
         {
-            return (Dictionary<String, ShowCommandModuleInfo>)_graphicalHostReflectionWrapper.CallStaticMethod("GetImportedModulesDictionary", new object[] { moduleObjects });
+            return (Dictionary<string, ShowCommandModuleInfo>)_graphicalHostReflectionWrapper.CallStaticMethod("GetImportedModulesDictionary", new object[] { moduleObjects });
         }
 
         internal List<ShowCommandCommandInfo> GetCommandList(object[] commandObjects)

src/Microsoft.PowerShell.Commands.Utility/commands/utility/WaitEventCommand.cs

@@ -62,7 +62,7 @@ public int Timeout
 
         private AutoResetEvent _eventArrived = new AutoResetEvent(false);
         private PSEventArgs _receivedEvent = null;
-        private object _receivedEventLock = new Object();
+        private object _receivedEventLock = new object();
         private WildcardPattern _matchPattern;
 
         /// <summary>
@@ -112,7 +112,7 @@ protected override void StopProcessing()
             _eventArrived.Set();
         }
 
-        private void ReceivedEvents_PSEventReceived(Object sender, PSEventArgs e)
+        private void ReceivedEvents_PSEventReceived(object sender, PSEventArgs e)
         {
             // If they want to wait on just any event
             if (_sourceIdentifier == null)