Enable CA1050: Declare types in namespaces (#13872)

Author: xtqqczze

.globalconfig

@@ -91,7 +91,7 @@ dotnet_diagnostic.CA1046.severity = none
 dotnet_diagnostic.CA1047.severity = suggestion
 
 # CA1050: Declare types in namespaces
-dotnet_diagnostic.CA1050.severity = suggestion
+dotnet_diagnostic.CA1050.severity = warning
 
 # CA1051: Do not declare visible instance fields
 dotnet_diagnostic.CA1051.severity = silent

test/xUnit/Asserts/PriorityAttribute.cs

@@ -3,13 +3,16 @@
 
 using System;
 
-[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
-public class TestPriorityAttribute : Attribute
+namespace PSTests.Internal
 {
-    public TestPriorityAttribute(int priority)
+    [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
+    public class PriorityAttribute : Attribute
     {
-        Priority = priority;
-    }
+        public PriorityAttribute(int priority)
+        {
+            Priority = priority;
+        }
 
-    public int Priority { get; }
+        public int Priority { get; }
+    }
 }

test/xUnit/Asserts/PriorityOrderer.cs

@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using PSTests.Internal;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
@@ -19,7 +20,7 @@ public IEnumerable<TTestCase> OrderTestCases<TTestCase>(IEnumerable<TTestCase> t
             {
                 int priority = 0;
 
-                foreach (IAttributeInfo attr in testCase.TestMethod.Method.GetCustomAttributes(typeof(TestPriorityAttribute).AssemblyQualifiedName))
+                foreach (IAttributeInfo attr in testCase.TestMethod.Method.GetCustomAttributes(typeof(PriorityAttribute).AssemblyQualifiedName))
                 {
                     priority = attr.GetNamedArgument<int>("Priority");
                 }

test/xUnit/csharp/test_PSConfiguration.cs

@@ -10,6 +10,7 @@
 using System.Threading;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
+using PSTests.Internal;
 using Xunit;
 
 namespace PSTests.Sequential
@@ -382,7 +383,7 @@ public PowerShellPolicyTests(PowerShellPolicyFixture fixture)
             this.fixture = fixture;
         }
 
-        [Fact, TestPriority(1)]
+        [Fact, Priority(1)]
         public void PowerShellConfig_GetPowerShellPolicies_BothConfigFilesNotEmpty()
         {
             fixture.SetupConfigFile1();
@@ -398,7 +399,7 @@ public void PowerShellConfig_GetPowerShellPolicies_BothConfigFilesNotEmpty()
             fixture.CompareTwoPolicies(userPolicies, fixture.CurrentUserPolicies);
         }
 
-        [Fact, TestPriority(2)]
+        [Fact, Priority(2)]
         public void PowerShellConfig_GetPowerShellPolicies_EmptyUserConfig()
         {
             fixture.SetupConfigFile2();
@@ -413,7 +414,7 @@ public void PowerShellConfig_GetPowerShellPolicies_EmptyUserConfig()
             fixture.CompareTwoPolicies(sysPolicies, fixture.SystemWidePolicies);
         }
 
-        [Fact, TestPriority(3)]
+        [Fact, Priority(3)]
         public void PowerShellConfig_GetPowerShellPolicies_EmptySystemConfig()
         {
             fixture.SetupConfigFile3();
@@ -428,7 +429,7 @@ public void PowerShellConfig_GetPowerShellPolicies_EmptySystemConfig()
             fixture.CompareTwoPolicies(userPolicies, fixture.CurrentUserPolicies);
         }
 
-        [Fact, TestPriority(4)]
+        [Fact, Priority(4)]
         public void PowerShellConfig_GetPowerShellPolicies_BothConfigFilesEmpty()
         {
             fixture.SetupConfigFile4();
@@ -441,7 +442,7 @@ public void PowerShellConfig_GetPowerShellPolicies_BothConfigFilesEmpty()
             Assert.Null(userPolicies);
         }
 
-        [Fact, TestPriority(5)]
+        [Fact, Priority(5)]
         public void PowerShellConfig_GetPowerShellPolicies_BothConfigFilesNotExist()
         {
             fixture.CleanupConfigFiles();
@@ -454,7 +455,7 @@ public void PowerShellConfig_GetPowerShellPolicies_BothConfigFilesNotExist()
             Assert.Null(userPolicies);
         }
 
-        [Fact, TestPriority(6)]
+        [Fact, Priority(6)]
         public void Utils_GetPolicySetting_BothConfigFilesNotEmpty()
         {
             fixture.SetupConfigFile1();
@@ -553,7 +554,7 @@ public void Utils_GetPolicySetting_BothConfigFilesNotEmpty()
             fixture.CompareConsoleSessionConfiguration(consoleSessionConfiguration, fixture.SystemWidePolicies.ConsoleSessionConfiguration);
         }
 
-        [Fact, TestPriority(7)]
+        [Fact, Priority(7)]
         public void Utils_GetPolicySetting_EmptyUserConfig()
         {
             fixture.SetupConfigFile2();
@@ -652,7 +653,7 @@ public void Utils_GetPolicySetting_EmptyUserConfig()
             fixture.CompareConsoleSessionConfiguration(consoleSessionConfiguration, fixture.SystemWidePolicies.ConsoleSessionConfiguration);
         }
 
-        [Fact, TestPriority(8)]
+        [Fact, Priority(8)]
         public void Utils_GetPolicySetting_EmptySystemConfig()
         {
             fixture.SetupConfigFile3();
@@ -752,7 +753,7 @@ public void Utils_GetPolicySetting_EmptySystemConfig()
             fixture.CompareConsoleSessionConfiguration(consoleSessionConfiguration, null);
         }
 
-        [Fact, TestPriority(9)]
+        [Fact, Priority(9)]
         public void Utils_GetPolicySetting_BothConfigFilesEmpty()
         {
             fixture.SetupConfigFile4();
@@ -852,7 +853,7 @@ public void Utils_GetPolicySetting_BothConfigFilesEmpty()
             fixture.CompareConsoleSessionConfiguration(consoleSessionConfiguration, null);
         }
 
-        [Fact, TestPriority(10)]
+        [Fact, Priority(10)]
         public void Utils_GetPolicySetting_BothConfigFilesNotExist()
         {
             fixture.CleanupConfigFiles();