Avoid array allocations from GetDirectories/GetFiles. (#14328)

xtqqczze · web-flow · commit 86ca45681dbf · 2020-12-07T15:20:58.000-08:00
diff --git a/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs b/src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
@@ -6096,7 +6096,7 @@ internal static List<CompletionResult> CompleteHelpTopics(CompletionContext cont
 
                 foreach (var dir in searchPaths)
                 {
-                    foreach (var file in Directory.GetFiles(dir))
+                    foreach (var file in Directory.EnumerateFiles(dir))
                     {
                         if (wildcardPattern.IsMatch(Path.GetFileName(file)))
                         {

Original file line number	Diff line number	Diff line change
`@@ -6096,7 +6096,7 @@ internal static List<CompletionResult> CompleteHelpTopics(CompletionContext cont`
`6096`	`6096`
`6097`	`6097`	`foreach (var dir in searchPaths)`
`6098`	`6098`	`{`
`6099`		`- foreach (var file in Directory.GetFiles(dir))`
	`6099`	`+ foreach (var file in Directory.EnumerateFiles(dir))`
`6100`	`6100`	`{`
`6101`	`6101`	`if (wildcardPattern.IsMatch(Path.GetFileName(file)))`
`6102`	`6102`	`{`