Skip to content

Commit 1f6e1e0

Browse files
author
joeyaiello
committed
change MSI rfc to use .cmd file for pwsh-preview
1 parent f348cf6 commit 1f6e1e0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

2-Draft-Accepted/RFCXXXX-MSI-Installation-Path.md renamed to 4-Experimental-Accepted/RFCXXXX-MSI-Installation-Path.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ We also provide the version of PowerShell in the FileVersion object associated w
4444
an in-place update of that preview build shall be performed.
4545
* No installation of a preview build shall interfere with a stable build, and vice versa
4646
* This includes an implicit requirement that `Install-PowerShellRemoting.ps1` create a different endpoint name for the preview build.
47-
* The preview binary of PowerShell Core 6.x shall be named `pwsh-preview` or `pwsh-preview.exe` (depending on the platform).
47+
* The preview of PowerShell Core 6.x shall not be placed on the `PATH`.
48+
Instead, we should create a subdirectory in `$PSHOME` called `bin`,
49+
create a `.cmd` file that launches the preview `pwsh.exe`,
50+
and add `$PSHOME\bin` to the `PATH`.
4851

4952
## Alternate Considerations and Proposals
5053

@@ -63,8 +66,6 @@ they should do a portable ZIP install.
6366

6467
## Open Questions
6568

66-
* What happens if `...\6\pwsh.exe` and `...\6-preview\pwsh.exe` are both on the PATH?
67-
Is it even desirable to put `...\6-preview\pwsh.exe` on the PATH?
6869
* Should an update install of stable PowerShell Core 6.0 to 6.1 also do a cleanup of any remaining preview 6.1 installs on the box?
6970
* I'd posit "no" because the stable vs. preview branches should be independent installations.
7071
E.g. I may want to immediately do an update of my preview 6.1 to 6.2,

0 commit comments

Comments
 (0)