Remove extraneous import-module commands in tests #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
approved these changes
Apr 5, 2018
There was a problem hiding this comment.
Looks good, I only left a minor and optional style comment. I also ran the tests of your branch on my machine on PS 5.1 and 6.0 (on Windows) and could not notice any regression. Although you marked it as WIP, I would already be happy for you to merge the current changes if you want to?
| Import-Module -Verbose PSScriptAnalyzer | ||
| $script:skipTest = $true | ||
| if ($PSVersionTable.PSVersion -ge [Version]'5.0.0') { | ||
| $script:skipTest = $false |
There was a problem hiding this comment.
Maybe use a more descriptive variable name like skipTestForv3andv4?
There was a problem hiding this comment.
sure, I've changed it - if it gets through CI I'll merge
The expectation is that these tests are run as part of the test harness, the re-importing of the module is unneeded
JamesWTruher
force-pushed
the
jameswtruher/SimplifyRuleTests01
branch
from
31ab8d5 to
b478613
Compare
JamesWTruher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The expectation is that these tests are run as part of the test harness, the re-importing of the module is unneeded. Also, module autoloading should take care of this in any event.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready