Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalise new -ReportSummary switch #895

Merged
merged 14 commits into from
Mar 2, 2018
Merged

Finalise new -ReportSummary switch #895

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
db5b759
added -ReportSummary switch to emit an additional single line count o…
StingyJack Feb 3, 2018
a8dbb1f
changing ReportSummary to write-host
StingyJack Feb 4, 2018
33ae40f
Add markdown file fix and test library mock for new -ReportSummary s…
bergmeister Feb 11, 2018
d57f62f
tweak reportSummary and add test
bergmeister Feb 17, 2018
5e1b1e0
convert tabs to spaces for consistency
bergmeister Feb 17, 2018
4a82407
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Feb 17, 2018
2af3584
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Feb 20, 2018
9c61a94
poke build
bergmeister Feb 20, 2018
608f5a4
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Feb 20, 2018
ccbc79c
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
bergmeister Feb 20, 2018
2570521
update to pester v4 syntax
bergmeister Feb 20, 2018
a15fc19
use built in warning/error methods to get colouring to work in a user…
bergmeister Feb 25, 2018
827df2c
try using helper class because writeerrorline did not work in CI
bergmeister Feb 25, 2018
3687c3f
make one helper private and add licence header
bergmeister Feb 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use built in warning/error methods to get colouring to work in a user… 
… setting agnostic way
  • Loading branch information
@bergmeister
bergmeister committed Feb 25, 2018
commit a15fc196052d0c02604f9ba22f550c93e79030fa
15 changes: 10 additions & 5 deletions Engine/Commands/InvokeScriptAnalyzerCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,15 +464,20 @@ private void WriteToOutput(IEnumerable<DiagnosticRecord> diagnosticRecords)
var numberOfRuleViolations = infoCount + warningCount + errorCount;
if (numberOfRuleViolations == 0)
{
Host.UI.WriteLine(foregroundColor: ConsoleColor.Green, backgroundColor: Host.UI.RawUI.BackgroundColor,
value: "0 rule violations found.");
Host.UI.WriteLine("0 rule violations found.");
}
else
{
var foregroundConsoleColor = warningCount + errorCount == 0 ? ConsoleColor.Yellow : ConsoleColor.Red;
var pluralS = numberOfRuleViolations > 1 ? "s" : string.Empty;
Host.UI.WriteLine(foregroundColor: foregroundConsoleColor, backgroundColor: Host.UI.RawUI.BackgroundColor,
value: $"{numberOfRuleViolations} rule violation{pluralS} found. Severity distribution: {DiagnosticSeverity.Error} = {errorCount}, {DiagnosticSeverity.Warning} = {warningCount}, {DiagnosticSeverity.Information} = {infoCount}");
var message = $"{numberOfRuleViolations} rule violation{pluralS} found. Severity distribution: {DiagnosticSeverity.Error} = {errorCount}, {DiagnosticSeverity.Warning} = {warningCount}, {DiagnosticSeverity.Information} = {infoCount}";
if (warningCount + errorCount == 0)
{
Host.UI.WriteWarningLine(message);
}
else
{
Host.UI.WriteErrorLine(message);
}
}
}
}
Expand Down