Fix regressions introduced by PR 882 #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- $IsWindows returns false on Windows PowerShell because this automatic variable was only introduced in PowerShell Core - some reverts of test code that did not fail due to the above.
bergmeister
changed the title
bergmeister
changed the title
JamesWTruher
approved these changes
Feb 20, 2018
| @@ -97,7 +97,7 @@ Describe "Test importing correct customized rules" { | |||
| $customizedRulePath.Count | Should Be 1 | |||
| } | |||
|
|
|||
| It "will show the custom rule when given a rule folder path with trailing backslash" -skip:(!$IsWindows){ | |||
| It "will show the custom rule when given a rule folder path with trailing backslash" -skip:$($IsLinux -or $IsMacOS) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When running the tests locally on Windows PowerShell after having pulled the latest changes in the development branch from PR #882, I noticed a regression (4 failed tests and 15 skipped tests);
$IsWindowsreturns false onWindows PowerShellbecause this automatic variable was only introduced inPowerShell Core. I have missed this detail during the review and therefore this was partially my fault.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready