Skip to content

Add UseSupportsShouldProcess rule #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 93 commits into from
May 16, 2017
Merged

Add UseSupportsShouldProcess rule #758

merged 93 commits into from
May 16, 2017

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented May 9, 2017

Also adds feature that allows PSSA to apply edits based on the corrections that a diagnostic record emits.

Resolves #568, #582

Kapil Borle added 30 commits March 31, 2017 11:47
Add skeleton of UseSupportsShouldProcess rule
e91ee78
Add basic checks for whatif and confirm
1364172
Add tests for manual adition of whatif and confirm
634056f
Update error string for UseSupportsShouldProcess rule
537695e
Add diagnostic record for UseSupportShouldProcess violation
0534133
Output ParamBlockAst from method to get parameter ast
ad527df
Update parameter retrieval logic
d824b53
Update tests to check suggested corrections
04eada9
Add TextEdit class
2a7c4e0
Add IScriptExtent.Contains extension method
f85ee3c
Add more IScriptExtension.Contains tests
5db9110
Add methods to apply edits to a string
8cdb366
Remove unnecessary extension methods
84f2cc0
Add EditableText class to edit strings
ca43a43
Add more tests to check IScriptExtent.Contains
8efd95d
Fix extensions test file name
dd236b7
Make EditableText class public
4e80f05
Add new contructor for TextEdit class
da1e8a5
Remove IScriptExtent.Contains method
f5f84b4 
This method can return erroneous result because we cannot really determine if a extent is completely contained in another extent unless we know their corresponding texts.
Update validation logic for TextEdit extent
a15c25e
Add tests for EditableText class
30eedf0
Remove TextEdit type's dependency on IScriptExtent
144863e
Remove EditableText type's dependency on IScriptExtent
93f0ace
Derive CorrectionExtent from TextEdit
842a26b
Add tests for TextEdit class
bce6563
Remove redundant cases from CorrectionExtent tests
b8e38a1
Add extension method to translate text coordinates
cbf182b
Add tests for IScriptExtent.Translate
e386685
Add type to represent position in a text file
ecda864
Add type to represent range in a text file
be1bb45
Kapil Borle added 21 commits May 5, 2017 17:20
Handle TextLines.Insert when index equals number of items
413a6ef
Localize error strings in Range class
847ac16
Fix TextEdit test cases
cb6f9c5
Add documentation to Range class
064eb77
Localize error strings in Position class
b1d6168
Add documentation to Position class
c34f370
Increment total number of rules by 1
dbbe574
Remove IScriptExtent.Translate method from extensions
5d0edd3
Make GetParameterAsts an extension method
71ac64a
Use extension method to get cmdletbinding attribute
49b5e0a
Add method to check for cmdletbinding attribute
489938a
Add extension method get supportsshouldprocess attribute ast
a0a84c1
Add extension method to get named attribute arg value
4fbdb3a
Suggest setting SupportsShouldProcess to true
86e580c
Remove IScriptExtent.Translate extension tests
add80dc
Add tests for extension methods
3226819
Change return type of FunctionDefinitionAst.GetParameters
5902d24
Add documentation to extension methods
b418142
Change IsTrue method name to GetValue
d4353b7
Add documentation for UseSupportsShouldProcess rule
ce07993
Add access qualifier to UseSupportsShouldProcess class
489b37f
daviwil
daviwil approved these changes May 15, 2017
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though now i'm really starting to see the need for a shared library between PSES and PSSA :)

@kapilmb
Copy link
Author

kapilmb commented May 16, 2017

@daviwil Thanks for going through the PR.

@kapilmb kapilmb merged commit c58dafd into development May 16, 2017
@kapilmb kapilmb deleted the kapilmb/use-should-process-rule branch May 16, 2017 02:56
@kapilmb kapilmb mentioned this pull request May 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviwil daviwil daviwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kapilmb @daviwil @msftclas