Skip to content

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented May 12, 2020

PR Summary

Fixes #1492 by checking if the variable name was already added. Also simplifying the code to be a HashSet<string> instead of a Dictionary<string,VariableExpressionAst> since the actual variable seems to be never used. Unfortunately I have to drop the IReadOnlyCollection for HashSet since we target .Net 4.5.2 and only starting with .Net 4.6, HashSet is implementing IReadOnlyCollection, see here.
cc @Jawz84

PR Checklist

…ame variable name is used in 2 different sessions.
@scott1138
Copy link

@bergmeister @rjmholt do you know when this will be added to a release?

@bergmeister
Copy link
Collaborator Author

@scott1138 We hope to release this next month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The rule 'UseUsingScopeModifierInNewRunspaces' throw an ArgumentException

3 participants