Merge pull request #540 from PowerShell/ChangeDscSwitchName

Change switch name from SaveDscResourceDependency to SaveDscDependency

Author: Kapil Borle

CHANGELOG.MD

@@ -5,7 +5,7 @@
     - This property emits text that can rectify the violation which triggered the rule.
     - The primary purpose of this feature is to enable quick-fix scenarios in editors (e.g. vscode)     
 - Add "Name" as a positional parameter in Get-ScriptAnalyzerRule
-- Add a `SaveDSCResourceDependency` switch to allow `Invoke-ScriptAnalyzer` to download a DSC Resource module from PSGallery in the event of a `ModuleNotFoundDuringParse` parse error.
+- Add a `SaveDscDependency` switch to allow `Invoke-ScriptAnalyzer` to download a DSC Resource module from PSGallery in the event of a `ModuleNotFoundDuringParse` parse error.
 - Add `remove` verb to `UseShouldProcessForStateChangingFunctions` rule
 - Add a `ScriptPath` property to Diagnostic Record that returns the full path of the script
 - Fix the parsing of `Settings` parameter value when a hashtable is given

Engine/Commands/InvokeScriptAnalyzerCommand.cs

@@ -194,12 +194,12 @@ public object Settings
         /// Resolve DSC resource dependency
         /// </summary>
         [Parameter(Mandatory = false)]
-        public SwitchParameter SaveDscResourceDependency
+        public SwitchParameter SaveDscDependency
         {
-            get { return saveDscResourceDependency; }
-            set { saveDscResourceDependency = value; }
+            get { return saveDscDependency; }
+            set { saveDscDependency = value; }
         }
-        private bool saveDscResourceDependency;
+        private bool saveDscDependency;
 #endif // !PSV3
 #endregion Parameters
 
@@ -242,7 +242,7 @@ protected override void ProcessRecord()
 
 #if !PSV3
             // TODO Support dependency resolution for analyzing script definitions
-            if (saveDscResourceDependency)
+            if (saveDscDependency)
             {
                 using (var rsp = RunspaceFactory.CreateRunspace())
                 {

Tests/Engine/InvokeScriptAnalyzer.tests.ps1

@@ -71,13 +71,13 @@ Describe "Test available parameters" {
 
     if (!$testingLibraryUsage)
     {
-        Context "SaveDSCResourceDependency parameter" {
+        Context "SaveDscDependency parameter" {
             It "has the parameter" {
-                $params.ContainsKey("SaveDscResourceDependency") | Should Be $true
+                $params.ContainsKey("SaveDscDependency") | Should Be $true
             }
 
             It "is a switch parameter" {
-                $params["SaveDscResourceDependency"].ParameterType.FullName | Should Be "System.Management.Automation.SwitchParameter"
+                $params["SaveDscDependency"].ParameterType.FullName | Should Be "System.Management.Automation.SwitchParameter"
             }
         }
     }