Skip to content

Add support for ACR when publishing scripts #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 4, 2024

Conversation

anamnavi
Copy link
Member

@anamnavi anamnavi commented Feb 23, 2024

PR Summary

Add support for scripts for ACR, for publish and install.
Add tests for scripts for publish.
Fix bug where ACR expects lowercase name but user provided input doesn't match it.

Still to do:
fix bug where there's a mismatch between actual version (that ends with 0) and user provided version that may have more or less versions.
Also versions cannot be expected to be in any order, they are only in order of when they were published. Fix this bug too.
PSResourceInfo.Type property will still reflect none when Find-PSResource or Get-InstalledPSResource is called for ACR resources. This will be fixed after cleanup refactor.

PR Context

Resolves #1578 #1568

PR Checklist

Copy link
Member

@alerickson alerickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add a test or add a validation in an existing test.

@alerickson
Copy link
Member

resolves #1578

@anamnavi anamnavi merged commit f84e572 into PowerShell:master Mar 4, 2024
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Apr 1, 2024
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACR - add resource type to package metadata
3 participants