-
Notifications
You must be signed in to change notification settings - Fork 98
Add support for ACR when publishing scripts #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerickson
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just add a test or add a validation in an existing test.
…to acr-script-type
alerickson
reviewed
Feb 29, 2024
test/PublishPSResourceTests/PublishPSResourceACRServer.Tests.ps1
Outdated
Show resolved
Hide resolved
resolves #1578 |
adityapatwardhan
requested changes
Feb 29, 2024
test/InstallPSResourceTests/InstallPSResourceACRServer.Tests.ps1
Outdated
Show resolved
Hide resolved
test/InstallPSResourceTests/InstallPSResourceACRServer.Tests.ps1
Outdated
Show resolved
Hide resolved
test/PublishPSResourceTests/PublishPSResourceACRServer.Tests.ps1
Outdated
Show resolved
Hide resolved
alerickson
approved these changes
Mar 1, 2024
adityapatwardhan
approved these changes
Mar 4, 2024
alerickson
pushed a commit
to alerickson/PSResourceGet
that referenced
this pull request
Apr 1, 2024
alerickson
pushed a commit
to alerickson/PSResourceGet
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add support for scripts for ACR, for publish and install.
Add tests for scripts for publish.
Fix bug where ACR expects lowercase name but user provided input doesn't match it.
Still to do:
fix bug where there's a mismatch between actual version (that ends with 0) and user provided version that may have more or less versions.
Also versions cannot be expected to be in any order, they are only in order of when they were published. Fix this bug too.
PSResourceInfo.Type property will still reflect none when Find-PSResource or Get-InstalledPSResource is called for ACR resources. This will be fixed after cleanup refactor.
PR Context
Resolves #1578 #1568
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.