Validate PSModuleInfo properties directly instead of checking pwsh.HadErrors first

Changed validation logic to check Author, Description, and Version properties on the result object directly, rather than only checking them when pwsh.HadErrors is true. This ensures proper validation with CurrentRunspace mode.

Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>

Author: Copilot

src/code/Utils.cs

@@ -1400,32 +1400,32 @@ public static bool ValidateModuleManifest(string moduleManifestPath, out string
                     }
                 }
 
-                if (pwsh.HadErrors)
+                // Validate the result object directly
+                if (results.Any())
                 {
-                    if (results.Any())
+                    PSModuleInfo psModuleInfoObj = results[0].BaseObject as PSModuleInfo;
+                    if (string.IsNullOrWhiteSpace(psModuleInfoObj.Author))
                     {
-                        PSModuleInfo psModuleInfoObj = results[0].BaseObject as PSModuleInfo;
-                        if (string.IsNullOrWhiteSpace(psModuleInfoObj.Author))
-                        {
-                            errorMsg = "No author was provided in the module manifest. The module manifest must specify a version, author and description. Run 'Test-ModuleManifest' to validate the file.";
-                        }
-                        else if (string.IsNullOrWhiteSpace(psModuleInfoObj.Description))
-                        {
-                            errorMsg = "No description was provided in the module manifest. The module manifest must specify a version, author and description. Run 'Test-ModuleManifest' to validate the file.";
-                        }
-                        else if (psModuleInfoObj.Version == null)
-                        {
-                            errorMsg = "No version or an incorrectly formatted version was provided in the module manifest. The module manifest must specify a version, author and description. Run 'Test-ModuleManifest' to validate the file.";
-                        }
+                        errorMsg = "No author was provided in the module manifest. The module manifest must specify a version, author and description. Run 'Test-ModuleManifest' to validate the file.";
+                        return false;
                     }
-
-                    if (string.IsNullOrEmpty(errorMsg))
+                    else if (string.IsNullOrWhiteSpace(psModuleInfoObj.Description))
                     {
-                        // Surface any inner error messages
-                        var innerErrorMsg = (pwsh.Streams.Error.Count > 0) ? pwsh.Streams.Error[0].ToString() : string.Empty;
-                        errorMsg = $"Module manifest file validation failed with error: {innerErrorMsg}. Run 'Test-ModuleManifest' to validate the module manifest.";
+                        errorMsg = "No description was provided in the module manifest. The module manifest must specify a version, author and description. Run 'Test-ModuleManifest' to validate the file.";
+                        return false;
                     }
-
+                    else if (psModuleInfoObj.Version == null)
+                    {
+                        errorMsg = "No version or an incorrectly formatted version was provided in the module manifest. The module manifest must specify a version, author and description. Run 'Test-ModuleManifest' to validate the file.";
+                        return false;
+                    }
+                }
+                
+                // Check for any errors from Test-ModuleManifest
+                if (pwsh.HadErrors)
+                {
+                    var innerErrorMsg = (pwsh.Streams.Error.Count > 0) ? pwsh.Streams.Error[0].ToString() : string.Empty;
+                    errorMsg = $"Module manifest file validation failed with error: {innerErrorMsg}. Run 'Test-ModuleManifest' to validate the module manifest.";
                     return false;
                 }
             }