Implement export Windows PowerShell adapter #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Gijsreyn
force-pushed
the
implement-export-winpsadapter
branch
from
1435850 to
353b76d
Compare
|
Hi @SteveL-MSFT, both #840 and this one had some issues with clippy, which are resolved in #855. Earlier builds succeeded because v1.86 didn't break anything. |
michaeltlombardi
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Minor nit - otherwise this looks coherent to me!
It reminded me that I hadn't finished filing #860, but this updates the Windows PowerShell adapter implementation to match the PowerShell adapter, so I don't see a reason to block this PR.
Co-authored-by: Mikey Lombardi (He/Him) <michael.t.lombardi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses #811. It adds the
exportcapability in the resource manifest and matches the logic used inMicrosoft.DSC/PowerShelladapter. Documentation added.