Fix no parsing expressions again when passed to an adapted resource#1031
Merged
SteveL-MSFT merged 3 commits intoPowerShell:mainfrom Aug 7, 2025
Merged
Fix no parsing expressions again when passed to an adapted resource#1031SteveL-MSFT merged 3 commits intoPowerShell:mainfrom
SteveL-MSFT merged 3 commits intoPowerShell:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes expression parsing for adapted resources by preventing double processing of DSC expressions. When adapted resources are used implicitly, the DSC engine creates a nested Configuration which attempts to re-parse expressions that were already processed by the parent Configuration, causing failures with string literals like [[this is a string literal].
- Adds a
process_expressionsflag to theConfiguratorto control expression processing - Updates
parse_and_execute()to accept a boolean parameter that bypasses expression processing whenfalse - Modifies adapted resource handling to disable expression processing for dynamically created configurators
Reviewed Changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
dsc_lib/src/parser/mod.rs |
Core parser changes to add process_expressions parameter and early return logic |
dsc_lib/src/configure/mod.rs |
Adds process_expressions field to Configurator and updates all expression parsing calls |
dsc_lib/src/dscresources/dscresource.rs |
Sets process_expressions to false for adapted resource configurations |
dsc_lib/src/configure/depends_on.rs |
Updates dependency parsing calls to use new parameter |
| Test files | Updates all unit tests to pass true for the new process_expressions parameter |
powershell-adapter/Tests/ |
Adds integration test and supporting test resource for the fix |
dsc_lib/locales/en-us.toml |
Adds localization string for debug message |
d6a4cb2 to
ea640f4
Compare
tgauth
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The problem is when it comes to implicit use of adapted resources, the DSC engine internally creates a Configuration and executes that. However, the outer Configuration has already had expressions parsed so that
[[this is a string literal]becomes[this is a string literal]and the nested configuration tries to parse that again and fails because it's invalid. The change is to have a new property on theConfiguratorindicating whether to process expressions and only in the case of a dynamically createdConfiguratorfor implicit adapted resources do we want to NOT process them as it was already processed by the parentConfigurator.This change adds a new property to
Contextto indicate whetherparse_and_execute()should process the expression or simply return the string back.Some tests unrelated to this change were found to be wrong and fixed.
PR Context
Fix #1024