Fix no parsing expressions again when passed to an adapted resource #1031
+45
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The problem is when it comes to implicit use of adapted resources, the DSC engine internally creates a Configuration and executes that. However, the outer Configuration has already had expressions parsed so that
[[this is a string literal]
becomes[this is a string literal]
and the nested configuration tries to parse that again and fails because it's invalid. The change is to have a new property on theConfigurator
indicating whether to process expressions and only in the case of a dynamically createdConfigurator
for implicit adapted resources do we want to NOT process them as it was already processed by the parentConfigurator
.This change adds a new property to
Context
to indicate whetherparse_and_execute()
should process the expression or simply return the string back.Some tests unrelated to this change were found to be wrong and fixed.
PR Context
Fix #1024