Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User/emray/refactor lean #256

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

User/emray/refactor lean #256

wants to merge 4 commits into from

Conversation

emreaydinceren
Copy link

@emreaydinceren emreaydinceren commented Oct 1, 2024 •
edited
Loading

PR Summary

  • Using Format-Table rather than built-in logic for formatting objects into tabular format.
    • Fixes the bug that alignment is wrong in numeric or datetime data types.
    • Reduces code base to maintain.
    • Allows benefit from Format-Table's Property feature (selecting visible columns and formatting them)
  • Made sure all namespaces are uniform.
  • Merged Models project to the main project (seems to serve no purpose, keeping models internal is better)

PR Context

  • The right and left alignment of columns were off.
  • Could not select which columns to show or hide.

emreaydinceren and others added 2 commits October 1, 2024 09:52
@emreaydinceren
- Refactor 2 projects into single project
b321382 
- Use Format-Table as formatter rather than built-in logic
    - Enabling styling via Format-Table's Properties feature
    - Fixing bug where columns were not aligned to right when appropriate
    - Reduce code base to maintain.
@emreaydinceren
Added back braces for namespace, dropping braces makes PR hard to read.
1c8c9cb
@andyleejordan andyleejordan requested a review from tig October 1, 2024 19:24
@emreaydinceren
Copy link
Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig Awaiting requested review from tig

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emreaydinceren