Fix code posting on macOS #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenBucher98
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #172
This PR fixes the following scenarios on macOS
/code postfrom theAIShellpane to post code to thePowerShellpaneInvoke-AIShell -PostCodefrom thePowerShellto request code to be posted from theAIShellpane.[NOTE] Now the
AIShellmodule depends on the v2.4.2-beta2 PSReadLine, because a private field was added in PSReadLine to accurately indicate if PSReadLine is initialized and ready to render (PowerShell/PSReadLine#4706).The
AIShellmodule starts to depend on that field to be more deterministic about if PSReadLine is running and ready. Before this change, we relied onConsole.TreatControlCAsInputwhich is not accurate and may cause race condition:Console.TreatControlCAsInputis set to true, butInitialize(...)is not called yet. Rendering the posted code before initialization could result in corrupted state -- posted code may be rendered on wrong position, or even cause exception.