Add graphics safety checks to prevent accessViolationExceptions

Author: Redninja106

src/SimulationFramework.SkiaSharp/SkiaCanvas.cs

@@ -6,7 +6,7 @@
 
 namespace SimulationFramework.SkiaSharp;
 
-internal sealed class SkiaCanvas : ICanvas
+internal sealed class SkiaCanvas : SkiaGraphicsObject, ICanvas
 {
     public ITexture Target { get; }
 
@@ -25,8 +25,6 @@ internal sealed class SkiaCanvas : ICanvas
 
     private SkiaTexture SkiaTextureTarget => Target as SkiaTexture;
 
-    public bool IsDisposed { get; private set; }
-
     public SkiaCanvas(SkiaGraphicsProvider provider, ITexture target, SKCanvas canvas, bool owner)
     {
         this.Target = target;
@@ -258,8 +256,11 @@ public void ResetState()
         currentState = new SkiaCanvasState(this.GetSKCanvas(), null);
     }
 
-    public void Dispose()
+    public override void Dispose()
     {
+        if (IsDisposed)
+            return;
+
         if (owner)
             canvas.Dispose();
 
@@ -269,7 +270,5 @@ public void Dispose()
         {
             stateStack.Pop().Dispose();
         }
-
-        this.IsDisposed = true;
     }
 }

src/SimulationFramework.SkiaSharp/SkiaCanvasState.cs

@@ -113,7 +113,7 @@ protected override void UpdateStrokeWidth(float strokeWidth)
 
     protected override void UpdateFillTexture(ITexture texture, Matrix3x2 transform, TileMode tileModeX, TileMode tileModeY)
     {
-        if (texture is not null)
+        if (texture is SkiaTexture skTexture)
         {
             bool changed = false;
             changed |= this.FillTexture != texture;
@@ -124,7 +124,7 @@ protected override void UpdateFillTexture(ITexture texture, Matrix3x2 transform,
             if (changed)
             {
                 this.fillTextureShader?.Dispose();
-                this.fillTextureShader = SKShader.CreateImage(SkiaInterop.GetImage(texture), tileModeX.AsSKShaderTileMode(), tileModeY.AsSKShaderTileMode(), transform.AsSKMatrix());
+                this.fillTextureShader = SKShader.CreateImage(skTexture.GetImage(), tileModeX.AsSKShaderTileMode(), tileModeY.AsSKShaderTileMode(), transform.AsSKMatrix());
             }
         }
 

src/SimulationFramework.SkiaSharp/SkiaFileFont.cs

@@ -28,6 +28,8 @@ public override SKTypeface GetTypeface(FontStyle style)
 
     public override void Dispose()
     {
+        if (IsDisposed)
+            return;
         typeface.Dispose();
         base.Dispose();
     }

src/SimulationFramework.SkiaSharp/SkiaGraphicsProvider.cs

@@ -72,8 +72,9 @@ public bool TryCreateTexture(int width, int height, ReadOnlySpan<Color> pixels,
 
             return true;
         }
-        catch
+        catch (Exception ex)
         {
+            Log.Error($"Error creating texture: " + ex);
             texture = null;
             return false;
         }

src/SimulationFramework.SkiaSharp/SkiaSystemFont.cs

@@ -62,6 +62,9 @@ public override SKTypeface GetTypeface(FontStyle style)
 
     public override void Dispose()
     {
+        if (IsDisposed)
+            return;
+
         regular.Dispose();
         bold?.Dispose();
         italic?.Dispose();

src/SimulationFramework.SkiaSharp/SkiaTexture.cs

@@ -72,6 +72,9 @@ public void InvalidatePixels()
 
     public override void Dispose()
     {
+        if (IsDisposed)
+            return;
+
         this.canvas.Dispose();
         this.surface.Dispose();
         this.image.Dispose();
@@ -106,6 +109,9 @@ private unsafe void UpdateLocalPixels()
 
     public unsafe void Update(ReadOnlySpan<Color> pixels)
     {
+        if (IsDisposed)
+            throw new InvalidOperationException("Cannot use disposed texture!");
+
         Color* buffer = null;
         try
         {
@@ -144,6 +150,9 @@ private void TextureFlip(ReadOnlySpan<Color> src, Span<Color> dest)
 
     public ICanvas GetCanvas()
     {
+        if (IsDisposed)
+            throw new InvalidOperationException("Cannot use disposed texture!");
+
         if (Options.HasFlag(TextureOptions.NonRenderTarget))
         {
             throw new InvalidOperationException("Cannot render to a texture with the TextureOptions.NonRenderTarget flag.");
@@ -164,21 +173,36 @@ public void ApplyChanges()
 
     public SKSurface GetSurface()
     {
+        if (IsDisposed)
+            throw new InvalidOperationException("Cannot use disposed texture!");
+
         return surface;
     }
 
     public SKImage GetImage()
     {
+        if (IsDisposed)
+
+            if (IsDisposed)
+                throw new InvalidOperationException("Cannot use disposed texture!");
+        throw new InvalidOperationException("Cannot use disposed texture!");
+
         return image;
     }
 
     public uint GetGLTexture()
     {
+        if (IsDisposed)
+            throw new InvalidOperationException("Cannot use disposed texture!");
+
         return glTexture;
     }
 
     public void Encode(Stream destination, TextureEncoding encoding)
     {
+        if (IsDisposed)
+            throw new InvalidOperationException("Cannot use disposed texture!");
+
         var data = image.Encode(encoding switch
         {
             TextureEncoding.PNG => SKEncodedImageFormat.Png,