refactor: split PROPERTY_OPERATORS into composable sub-groups

Break the flat tuple into category-specific tuples (EQUALITY_OPERATORS,
STRING_OPERATORS, etc.) that compose into PROPERTY_OPERATORS via
concatenation. The semver dispatch code now references
SEMVER_OPERATORS and SEMVER_COMPARISON_OPERATORS instead of
repeating the full operator lists inline.

Author: dmarticus

posthog/feature_flags.py

@@ -19,35 +19,27 @@
 NONE_VALUES_ALLOWED_OPERATORS = ["is_not"]
 
 # All operators supported by match_property, grouped by category.
-PROPERTY_OPERATORS = (
-    # Equality
-    "exact",
-    "is_not",
-    "is_set",
-    "is_not_set",
-    # String matching
-    "icontains",
-    "not_icontains",
-    "regex",
-    "not_regex",
-    # Numeric / string comparison
-    "gt",
-    "gte",
-    "lt",
-    "lte",
-    # Date comparison
-    "is_date_before",
-    "is_date_after",
-    # Semver comparison
+EQUALITY_OPERATORS = ("exact", "is_not", "is_set", "is_not_set")
+STRING_OPERATORS = ("icontains", "not_icontains", "regex", "not_regex")
+NUMERIC_OPERATORS = ("gt", "gte", "lt", "lte")
+DATE_OPERATORS = ("is_date_before", "is_date_after")
+SEMVER_COMPARISON_OPERATORS = (
     "semver_eq",
     "semver_neq",
     "semver_gt",
     "semver_gte",
     "semver_lt",
     "semver_lte",
-    "semver_tilde",
-    "semver_caret",
-    "semver_wildcard",
+)
+SEMVER_RANGE_OPERATORS = ("semver_tilde", "semver_caret", "semver_wildcard")
+SEMVER_OPERATORS = SEMVER_COMPARISON_OPERATORS + SEMVER_RANGE_OPERATORS
+
+PROPERTY_OPERATORS = (
+    EQUALITY_OPERATORS
+    + STRING_OPERATORS
+    + NUMERIC_OPERATORS
+    + DATE_OPERATORS
+    + SEMVER_OPERATORS
 )
 
 
@@ -540,32 +532,15 @@ def compare(lhs, rhs, operator):
                 "The date provided must be a string or date object"
             )
 
-    if operator in (
-        "semver_eq",
-        "semver_neq",
-        "semver_gt",
-        "semver_gte",
-        "semver_lt",
-        "semver_lte",
-        "semver_tilde",
-        "semver_caret",
-        "semver_wildcard",
-    ):
+    if operator in SEMVER_OPERATORS:
         try:
             override_parsed = parse_semver(override_value)
         except (ValueError, TypeError):
             raise InconclusiveMatchError(
                 f"Person property value '{override_value}' is not a valid semver"
             )
 
-        if operator in (
-            "semver_eq",
-            "semver_neq",
-            "semver_gt",
-            "semver_gte",
-            "semver_lt",
-            "semver_lte",
-        ):
+        if operator in SEMVER_COMPARISON_OPERATORS:
             try:
                 flag_parsed = parse_semver(value)
             except (ValueError, TypeError):