This repository was archived by the owner on Jul 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
fix: check if window is available before using on web env #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +463 B (+0.43%) Total Size: 109 kB
ℹ️ View Unchanged
|
marandaneto
commented
Sep 10, 2024
Comment on lines
-96
to
-98
if (!window) { | ||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkStoreIsSupported
is only called if there's a window
benjackwhite
suggested changes
Sep 10, 2024
Co-authored-by: Ben White <ben@posthog.com>
Co-authored-by: Ben White <ben@posthog.com>
pauldambra
reviewed
Dec 9, 2024
benjackwhite
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes https://github.com/PostHog/posthog-js-lite/issues/255
Similar to #57
Changes
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes