pulseaudio: Rework stopping code that it should prevent artifacts #965
Conversation
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
7c6247c to
d47968e
Compare
RossBencina
added
the
src-pulseaudio
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
d47968e to
ba5ec87
Compare
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
ba5ec87 to
77d4d46
Compare
|
This could take a look now that other one is fixed. |
There was a problem hiding this comment.
Github won't let me add a comment to an unchanged line, but at line 429 call to pa_steam_write, nothing has been copied to bufferData yet. Furthermore, bufferData memory is invalidated by the call (see https://freedesktop.org/software/pulseaudio/doxygen/stream_8h.html#a4fc69dec0cc202fcc174125dc88dada7 ) so subsequent calls to the buffer processor may crash.
I suggest moving the calls to PaUtil_EndBufferProcessing and PaUtil_EndCpuLoadMeasurement prior to the call to pa_stream_write.
There was a problem hiding this comment.
Hopefully I understood correctly what you meant with this but now it should be like that.
|
@illuusio we're awaiting your response to latest review. |
Sorry been bit busy but now it should be fixed as soon as I got the commits in 🦄 |
|
Ok this PR seems this one needs bit more work I separated that output thing to PR #1005 . Let's get that first in so I can solve last bits in this. Sorry about bit of wasting of your time.. |
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
77d4d46 to
26b88ed
Compare
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
26b88ed to
9eb105f
Compare
…d for clarity and specificity. The comments in _PaPulseAudio_ProcessAudio required enhancement; therefore, the comments have been revised to provide greater specificity and improved clarity in the English language.
…ated. The remaining comments in the PulseAudio callback file should be updated to utilize passive voice and improved English for clarity.
Make more adjustments to pulseaudio cb comments.
As Ringbuffer it does not underrun but it does overrun data. Co-authored-by: Ross Bencina <rossb@audiomulch.com>
Simplify comment about buffer size calculation Co-authored-by: Ross Bencina <rossb@audiomulch.com>
Update unlocking comment wording to more understandable Co-authored-by: Ross Bencina <rossb@audiomulch.com>
Output copying what in incorrect place now that should be corrected
Rework stopping and stream closing code as it should prevent artifacts when closing or stopping stream. Correctly handle stream termination from callback
illuusio
force-pushed
the
pulseaudio-remove-last-click
branch
from
9eb105f to
65a12bd
Compare
|
This PR contains a whole bunch of unrelated changes, mostly comment edits. Please reduce this to a minimal change against master that does what it claims to do: "rework stopping code to prevent artifacts." |
3 participants
Rework stopping and stream closing code as it should prevent artifacts when closing or stopping stream. Correctly handle stream termination from callback