fix: use the correct method of verification

Author: Victor Wiebe

src/procedures/__tests__/ControllerTransfer.ts

@@ -78,9 +78,13 @@ describe('ControllerTransfer', () => {
       await target.prepareTransactions();
 
       // Verifications
+
       expect(
-        addTransactionSpy.withArgs(securityTokenMock.getMockInstance().controllerTransfer).callCount
-      ).toBe(1);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(securityTokenMock.getMockInstance().controllerTransfer)
+      ).toEqual(true);
+      expect(addTransactionSpy.callCount).toEqual(1);
     });
 
     test('should throw if there is no valid security token supplied', async () => {

src/procedures/__tests__/CreateCheckpoint.ts

@@ -50,10 +50,7 @@ describe('CreateCheckpoint', () => {
     contextMock.set('contractWrappers', wrappersMock.getMockInstance());
     wrappersMock.set('tokenFactory', tokenFactoryMock.getMockInstance());
 
-    checkpointFactoryMock = ImportMock.mockClass(
-      checkpointFactoryModule,
-      'CheckpointFactory'
-    );
+    checkpointFactoryMock = ImportMock.mockClass(checkpointFactoryModule, 'CheckpointFactory');
     const factoryMockSetup = mockFactories();
     factoryMockSetup.checkpointFactory = checkpointFactoryMock.getMockInstance();
     contextMock.set('factories', factoryMockSetup);
@@ -85,8 +82,11 @@ describe('CreateCheckpoint', () => {
       await target.prepareTransactions();
       // Verifications
       expect(
-        addTransactionSpy.withArgs(securityTokenMock.getMockInstance().controllerTransfer).callCount
-      ).toBe(1);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(securityTokenMock.getMockInstance().controllerTransfer)
+      ).toEqual(true);
+      expect(addTransactionSpy.callCount).toEqual(1);
     });
 
     test('should throw if corresponding checkpoint event is not fired', async () => {

src/procedures/__tests__/CreateErc20DividendDistribution.ts

@@ -113,15 +113,16 @@ describe('CreateErc20DividendDistribution', () => {
       await target.prepareTransactions();
 
       // Verifications
+      expect(addProcedureSpy.getCall(0).calledWith(ApproveErc20)).toEqual(true);
       expect(
-        addTransactionSpy.withArgs(erc20DividendsMock.getMockInstance().setWithholding).callCount
-      ).toBe(1);
-      expect(
-        addTransactionSpy.withArgs(
-          erc20DividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
-        ).callCount
-      ).toBe(1);
-      expect(addProcedureSpy.withArgs(ApproveErc20).callCount).toBe(1);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(
+            erc20DividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
+          )
+      ).toEqual(true);
+      expect(addTransactionSpy.callCount).toEqual(1);
+      expect(addProcedureSpy.callCount).toEqual(1);
     });
 
     test('should send the transaction to CreateErc20DividendDistribution with taxWitholdings', async () => {
@@ -149,15 +150,19 @@ describe('CreateErc20DividendDistribution', () => {
       await target.prepareTransactions();
 
       // Verifications
+      expect(addProcedureSpy.getCall(0).calledWith(ApproveErc20)).toEqual(true);
       expect(
-        addTransactionSpy.withArgs(erc20DividendsMock.getMockInstance().setWithholding).callCount
-      ).toBe(2);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(
+            erc20DividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
+          )
+      ).toEqual(true);
       expect(
-        addTransactionSpy.withArgs(
-          erc20DividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
-        ).callCount
-      ).toBe(2);
-      expect(addProcedureSpy.withArgs(ApproveErc20).callCount).toBe(1);
+        addTransactionSpy.getCall(1).calledWith(erc20DividendsMock.getMockInstance().setWithholding)
+      ).toEqual(true);
+      expect(addTransactionSpy.callCount).toEqual(2);
+      expect(addProcedureSpy.callCount).toEqual(1);
     });
 
     test('should throw if there is no valid security token supplied', async () => {

src/procedures/__tests__/CreateEtherDividendDistribution.ts

@@ -14,6 +14,7 @@ import * as contextModule from '../../Context';
 import * as wrappersModule from '../../PolymathBase';
 import * as tokenFactoryModule from '../../testUtils/MockedTokenFactoryObject';
 import { mockFactories } from '~/testUtils/MockFactories';
+import { ApproveErc20 } from '~/procedures';
 
 const params1 = {
   symbol: 'TEST1',
@@ -98,13 +99,13 @@ describe('CreateEtherDividendDistribution', () => {
 
       // Verifications
       expect(
-        addTransactionSpy.withArgs(etherDividendsMock.getMockInstance().setWithholding).callCount
-      ).toBe(1);
-      expect(
-        addTransactionSpy.withArgs(
-          etherDividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
-        ).callCount
-      ).toBe(1);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(
+            etherDividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
+          )
+      ).toEqual(true);
+      expect(addTransactionSpy.callCount).toEqual(1);
     });
 
     test('should send the transaction to CreateEtherDividendDistribution with taxwithholdings', async () => {
@@ -132,13 +133,16 @@ describe('CreateEtherDividendDistribution', () => {
 
       // Verifications
       expect(
-        addTransactionSpy.withArgs(etherDividendsMock.getMockInstance().setWithholding).callCount
-      ).toBe(2);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(
+            etherDividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
+          )
+      ).toEqual(true);
       expect(
-        addTransactionSpy.withArgs(
-          etherDividendsMock.getMockInstance().createDividendWithCheckpointAndExclusions
-        ).callCount
-      ).toBe(2);
+        addTransactionSpy.getCall(1).calledWith(etherDividendsMock.getMockInstance().setWithholding)
+      ).toEqual(true);
+      expect(addTransactionSpy.callCount).toEqual(2);
     });
 
     test('should throw if corresponding event is not fired', async () => {

src/procedures/__tests__/CreateSecurityToken.ts

@@ -192,11 +192,14 @@ describe('CreateSecurityToken', () => {
 
       // Verifications
       expect(
-        addTransactionSpy.withArgs(
-          securityTokenRegistryMock.getMockInstance().generateNewSecurityToken
-        ).callCount
-      ).toBe(1);
-      expect(addProcedureSpy.withArgs(ApproveErc20).callCount).toBe(1);
+        addTransactionSpy
+          .getCall(0)
+          .calledWith(securityTokenRegistryMock.getMockInstance().generateNewSecurityToken)
+      ).toEqual(true);
+
+      expect(addTransactionSpy.callCount).toEqual(1);
+      expect(addProcedureSpy.getCall(0).calledWith(ApproveErc20)).toEqual(true);
+      expect(addProcedureSpy.callCount).toEqual(1);
     });
 
     test('should send the transaction to CreateSecurityToken with a treasury wallet', async () => {