Skip to content

Commit

Permalink
fix: descriptions and unnecessary code in two procedures
Browse files Browse the repository at this point in the history
  • Loading branch information
Victor Wiebe committed Dec 20, 2019
1 parent b19f267 commit 59ba9e5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
10 changes: 5 additions & 5 deletions src/procedures/__tests__/InvestInSimpleSto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { Factories } from '../../Context';
import { SimpleSto, SecurityToken } from '../../entities';
import * as securityTokenFactoryModule from '../../entities/factories/SecurityTokenFactory';
import { Wallet } from '../../Wallet';
import { ApproveErc20 } from '~/procedures';
import { ApproveErc20 } from '../../procedures';

const simpleParams: InvestInSimpleStoProcedureArgs = {
symbol: 'TEST1',
Expand Down Expand Up @@ -231,7 +231,7 @@ describe('InvestInSimpleSto', () => {
);
});

test('should throw an error if the simple sto has not been launched or is archived', async () => {
test('should throw an error if the simple sto has not yet been launched or is archived', async () => {
moduleWrapperFactoryMock.mock('getModuleInstance', Promise.resolve(undefined));

await expect(target.prepareTransactions()).rejects.toThrow(
Expand Down Expand Up @@ -272,7 +272,7 @@ describe('InvestInSimpleSto', () => {
);
});

test('should throw an error if the sto is already finalized', async () => {
test('should throw an error if the sto has already been finalized', async () => {
simpleStoFactoryMock.mock('fetch', {
...simpleStoObject,
isFinalized: true,
Expand All @@ -286,7 +286,7 @@ describe('InvestInSimpleSto', () => {
);
});

test('should throw an error if the start date is in the future', async () => {
test('should throw an error if the sto start date is in the future', async () => {
simpleStoFactoryMock.mock('fetch', {
...simpleStoObject,
startDate: new Date(2040, 0),
Expand All @@ -300,7 +300,7 @@ describe('InvestInSimpleSto', () => {
);
});

test('should throw an error if beneficial investments not allowed, and the parameters include a beneficiary address', async () => {
test('should throw an error if beneficial investments are not allowed and the parameters include a beneficiary address', async () => {
target = new InvestInSimpleSto(
{ ...simpleParams, beneficiary: beneficiaryAddress },
contextMock.getMockInstance()
Expand Down
2 changes: 0 additions & 2 deletions src/procedures/__tests__/LaunchSimpleSto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { restore, spy } from 'sinon';
import * as contractWrappersModule from '@polymathnetwork/contract-wrappers';
import {
BigNumber,
CappedSTOFundRaiseType as CappedStoCurrency,
SecurityTokenEvents,
TransactionReceiptWithDecodedLogs,
} from '@polymathnetwork/contract-wrappers';
Expand All @@ -28,7 +27,6 @@ import { Wallet } from '../../Wallet';
import { TransferErc20 } from '..';
import { mockFactories } from '../../testUtils/mockFactories';
import { SimpleSto, SecurityToken } from '../../entities';
import { PostTransactionResolver } from '../../PostTransactionResolver';

const params: LaunchSimpleStoProcedureArgs = {
symbol: 'TEST1',
Expand Down

0 comments on commit 59ba9e5

Please sign in to comment.