Update ST20Generator.js #531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters of the allowance function is incorrect
F-OBrien
reviewed
Jan 18, 2019
| @@ -187,7 +187,7 @@ async function approvePoly(spender, fee) { | |||
| polyBalance = await polyToken.methods.balanceOf(Issuer.address).call(); | |||
| let requiredAmount = web3.utils.toWei(fee.toString(), "ether"); | |||
| if (parseInt(polyBalance) >= parseInt(requiredAmount)) { | |||
| let allowance = await polyToken.methods.allowance(spender, Issuer.address).call(); | |||
| let allowance = await polyToken.methods.allowance(Issuer.address, spender).call(); | |||
| if (allowance == web3.utils.toWei(fee.toString(), "ether")) { | |||
There was a problem hiding this comment.
Suggested change
| if (allowance == web3.utils.toWei(fee.toString(), "ether")) { | |
| if (allowance >= web3.utils.toWei(fee.toString(), "ether")) { |
|
This issue is also present in investor_portal.js |
|
Thanks @cdlgz and @F-OBrien, those are actually bugs on the CLI. As I haven't started working on 3.0.0 CLI, I included these fixes on 2.1.0 branch, where it is the most updated CLI. I'll close this PR to avoid confusion, but thanks a lot again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters of the allowance function is incorrect
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
What is the current behavior?
(You can also link to an open issue here)
What is the new behavior?
(Define and describe any new functionality. Clarify if this is a feature change)
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Any Other information: