Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit production builds #46

Open
RafaelVidaurre opened this issue Sep 28, 2018 · 2 comments
Open

Revisit production builds #46

RafaelVidaurre opened this issue Sep 28, 2018 · 2 comments
Labels
enhancement New feature or request Github For Asana integration use only

Comments

@RafaelVidaurre
Copy link
Contributor

RafaelVidaurre commented Sep 28, 2018 •
edited
Loading

A sort of hacky fix (Setting NODE_ENV to development on build time) had to be put in place to allow production builds to work. This was merged in #45

This issue is for taking the time to look into this as a team and figure out how to deal properly with this issue.
@Grsmto
Copy link
Contributor

Grsmto commented Sep 28, 2018

Would be a good idea to check at CRA as they are releasing v2 with Webpack4 + Babel7 support so our solution is probably there. Also they are dropping support for monorepo (bit scary for us) but I'm not sure what this means but worth having a look:
https://gist.github.com/gaearon/8650d1c70e436e5eff01f396dffc4114#monorepo-support-from-2x-alphas-was-removed-in-final-20

@RafaelVidaurre
Copy link
Contributor Author

Definitely worth looking at!

@RafaelVidaurre RafaelVidaurre added enhancement New feature or request Github For Asana integration use only labels Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Github For Asana integration use only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Grsmto @RafaelVidaurre