Set household_weight default value to 1 #6864
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 3.13, microdf errors when running household simulations that don't provide weights because the default value of 0 causes division issues. This sets the default to 1, which represents a single household and allows simulations to work without explicitly setting weights. Closes PolicyEngine#6400 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6864 +/- ##
============================================
+ Coverage 72.92% 100.00% +27.07%
============================================
Files 3252 1 -3251
Lines 46840 8 -46832
Branches 243 0 -243
============================================
- Hits 34159 8 -34151
+ Misses 12667 0 -12667
+ Partials 14 0 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets the
household_weightvariable's default value to 1 instead of 0.In Python 3.13, microdf errors when running household simulations that don't provide weights because the default value of 0 causes division issues. Setting the default to 1 represents a single household and allows simulations to work without explicitly setting weights.
Closes #6400
Test plan
🤖 Generated with Claude Code