Add English names for missing location name entries and missing Kitakami and Blueberry locations #1233
Conversation
…ames. clarify names of Coastlands and Heights base camps in Hisui
jemarq04
changed the title
|
Hi, the build system had some problems, could you add a commit to the PR or close/reopen it? |
Ok, that should've worked. I'm not sure why there were problems as this branch modified different files, but after pulling the master branch back into it everything seems ok now. I'll monitor these checks. |
phalt
left a comment
phalt
left a comment
There was a problem hiding this comment.
Great contributions, thank you.
data/v2/csv/locations.csv
Outdated
| 1054,5,roaming-unova | ||
| 1055,3,mossdeep-space-center | ||
| 1056,6,roaming-kalos | ||
| 1057,9,uva-academy |
data/v2/csv/location_names.csv
Outdated
| 901,9,Giant's Foot, | ||
| 902,9,Giant's Mirror, | ||
| 903,9,Giant's Seat, | ||
| 904,9,503 Backend fetch failed, |
There was a problem hiding this comment.
My heart dropped when I almost left that in the PR! Running the script again resolved it, so I'm unsure how it happened. I'll definitely be on the lookout for things like that in the future haha
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
4 participants
Add entries in
location_names.csvfor missing location IDs. Only English names are added in these commits. Additionally, a couple typos were fixed inlocations.csv: 'cemetary' to 'cemetery', 'mauville-space-center' to 'mossdeep-space-center', and 'spike-decision' to 'split-decision'. Lastly, 'naranja-academy/uva-academy' was split to 'naranja-academy' and 'uva-academy', since these are distinct locations.The English names were retrieved using a script that queries Bulbapedia with the name in
locations.csv- any pages that were not redirected to their appropriate page were corrected manually. For reproducibility, the URL used was "https://bulbapedia.bulbagarden.net/wiki/Special:Search/NAME" with "NAME" replaced to each name inlocations.csvthat was not present inlocation_names.csv(e.g. 'split-decision-ruins').Edit: I also added missing locations within Kitakami and Blueberry Academy from the Scarlet/Violet DLC. Once again, this used Bulbapedia: