Taxon patch

[MichielStock]

As requested in Issue #17, I wrote a function to query when the ID of the species is known.

Not 100% finished (e.g. no unit test at the moment).

Ping @tpoisot to take a look.

@tpoisot edit: will fix #17 when merged

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@dc07397). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage          ?   57.22%           
=========================================
  Files             ?        9           
  Lines             ?      166           
  Branches          ?        0           
=========================================
  Hits              ?       95           
  Misses            ?       71           
  Partials          ?        0

Impacted Files	Coverage Δ
src/taxon.jl	26% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc07397...8613b3c. Read the comment docs.

[tpoisot]

Seems good, except for the one comment about allowing missing in one more place.

[tpoisot]

It's also missing the tests!

[MichielStock]

Done!

…

On 8 Mar 2019, at 14:14, Timothée Poisot ***@***.***> wrote: It's also missing the tests! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFvXo0l77HQE9A7OCQOt2CnvDjwsHHCgks5vUmJOgaJpZM4bgX8G>.

[mkborregaard]

@tpoisot I can see you've approved the PR but tests are failing (at least on Travis, seems to be in filtering), and there's still the open comment on missing?
(as an aside - should we start using the testset functionality? The Travis report is not very informative about where the error is being thrown.

[MichielStock]

@tpoisot I can see you've approved the PR but tests are failing (at least on Travis, seems to be in filtering), and there's still the open comment on missing?

I did not change anything in filtering, and there is a similar error in an other branch. This seems like an issue unrelated to my patch.

[mkborregaard]

Great - what's your take on the missing thing? Did you solve this and I didn't notice or did you disagree?

[mkborregaard]

Awesome work @MichielStock !

[tpoisot]

@tpoisot I can see you've approved the PR but tests are failing (at least on Travis, seems to be in filtering), and there's still the open comment on missing?

I did not change anything in filtering, and there is a similar error in an other branch. This seems like an issue unrelated to my patch.

I will have to see what is happening. I probably have written tests that can fail/pass depending on the state of the most recent data, so I'll need to write something that I know for sure will behave.