Fix behavior of SACMODEL_PARALLEL_LINE #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, does this pull request fixes #918? I'll take a look at it later today. |
|
No, that issue is about planes, this one is about lines. |
taketwo
force-pushed
the
fix-parallel-line
branch
from
cba7a99
to
bd3ae1e
Compare
The old condition checked if the line model is perpendicular to the axis provided by user, while according to the name of the class and documentation it should rather check if the line model is parallel to the axis.
Additionaly rename test_sample_consensus_line_model to reflect the fact that now it tests multiple line models.
taketwo
force-pushed
the
fix-parallel-line
branch
from
bd3ae1e
to
dba2a7b
Compare
|
@jspricke Can we merge this as well? |
jspricke
added a commit
that referenced
this pull request
Nov 22, 2014
Fix behavior of SACMODEL_PARALLEL_LINE
|
Sure, thanks for the ping :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the behavior of
SACMODEL_PARALLEL_LINEand makes some clean up in the related files.Despite the name and in contradiction with the documentation, currently the model searches for lines perpendicular to the given axis. This issue has been brought up on the mailing list a long while ago, but no action was taken at that time.
The additional commits in this pull request:
SACMODEL_LINEandSACMODEL_PARALLEL_LINEin separatecppfiles;constqualifiers where appropriate;SACMODEL_PARALLEL_LINEwith the new, correct behavior.