Add removeAllCoordinateSystems and templated addPointCloudPrincipalCurvatures

[aecins]

• removeAllCoordinateSystems removes all coordinate systems from the visualizer.
• Currently addPointCloudPrincipalCurvatures only accepts pcl::PointXYZ and pcl::Normal. It is now templated on the PointT and PointNT.

[taketwo]

Thanks for the contribution. Now that the function is templated, shouldn't the old implementation in pcl_visualizer.cpp be removed?

Also, please remove the first two commits from this pull request.

[aecins]

I have updated the code. I have removed the old implementation from pcl_visualizer.cpp. However I also had to remove the non-templated version of addPointCloudPrincipalCurvatures entirely and update the pcd_viewer.cpp accordingly.

[taketwo]

remove the non-templated version of addPointCloudPrincipalCurvatures entirely

Could you please really delete it (rather than comment)? Also please do not change formatting of lines that are out of scope of your pull request (addArrow function in this case).

[aecins]

I have reverted the changes to the formatting of addArrow and as far as I can see there is no code for non-templated addPointCloudPrincipalCurvatures. Have I missed any other issues?

[taketwo]

there is no code for non-templated addPointCloudPrincipalCurvatures

What about this one? Let's delete it, I think there is no point in keeping dead code around.

[aecins]

My bad, I couldn't find these changes in the diff. I have removed those commented lines.

[taketwo]

Thank you. Last thing: could you please squash the last two fixup commits into the first one?

[aecins]

I am a little confused. Should I just squash the last two commits into a single "fixup" commit? Or should I squash them into the first commit "Adde removeAllCoordinateSystems"? I thought you can only squash consecutive commits. I am new to git so maybe I am wrong.

[taketwo]

I thought you can only squash consecutive commits.

Not necessarily. When you are exposed with the interactive rebase "interface" (that is, an editor with lines presenting individual commits), you can swap the order of commits by moving their respective lines up or down.

Should I just squash the last two commits into a single "fixup" commit? Or should I squash them into the first commit "Adde removeAllCoordinateSystems"?

The latter. The intention is not to have a series of commits where one adds some lines, and the next one removes them. This pollutes the history with unnecessary commits and also makes usage of tools like git blame more complicated.

[aecins]

Alright, I think I did it. I did not realize you could rearrange lines in the rebase interface. Thanks for the tip!

[taketwo]

Great! Thanks for contributing.